Spec URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp.spec SRPM URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp-1.0.0-0.svn87622.1.fc9.src.rpm Description: gnome-keyring-sharp is a fully managed implementation of libgnome-keyring. When the gnome-keyring-daemon is running, you can use this to retrive/store confidential information such as passwords, notes or network services user information. (note: needed to update gnome-do to 0.5.0.1 release)
BAD source files match upstream: - MD5 matches but tarball name is gnome-keyring-sharp.tar.gz?view=tar not gnome-keyring-sharp.tar.gz BAD package meets naming and versioning guidelines. - Appears to contain an extra 1 appended to the dist tag OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. N/A latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in koji (Rawhide/x86_64). BAD debuginfo package looks complete. - Debuginfo package is empty, debug package need to be disabled OK rpmlint is silent. - only contains the standard bogus warnings for Mono packages OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, correct scriptlets exist OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK pkgconfig files are in devel subpackage N/A no libtool .la droppings. OK not a GUI app. Also I apologize for forgetting to do this review yesterday, I got drowned by bugzilla spam.
Updated, with the following changes: - tarball renamed (I was using the name that wget and Firefox creates when downloading, with the HTTP GET option not removed) - -debuginfo package turned off The naming convention is because this is not a stable release yet, however, I just realized that the official recommendation is slightly different: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages so I've adjusted the package accordingly. Spec URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp.spec SRPM URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp-1.0.0-2.87622svn.fc9.src.rpm
Corrected links: Spec URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp.spec SRPM URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp-1.0.0-0.2.87622svn.fc9.src.rpm
Looks good to me. Approved
New Package CVS Request ======================= Package Name: gnome-keyring-sharp Short Description: Mono implementation of GNOME Keyring Owners: salimma Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
Thanks. Built for Rawhide, will build and test GNOME-Do against it and then push it to F-9 and the rest