Bug 454229 - Review Request: gnome-keyring-sharp - Mono implementation of GNOME Keyring
Review Request: gnome-keyring-sharp - Mono implementation of GNOME Keyring
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-06 22:16 EDT by Michel Alexandre Salim
Modified: 2008-07-15 10:37 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-15 10:37:24 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
gnomeuser: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Michel Alexandre Salim 2008-07-06 22:16:59 EDT
Spec URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp.spec
SRPM URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp-1.0.0-0.svn87622.1.fc9.src.rpm
Description:
gnome-keyring-sharp is a fully managed implementation of libgnome-keyring.

When the gnome-keyring-daemon is running, you can use this to retrive/store
confidential information such as passwords, notes or network services user
information.

(note: needed to update gnome-do to 0.5.0.1 release)
Comment 1 David Nielsen 2008-07-08 08:54:28 EDT
BAD	source files match upstream:
- MD5 matches but tarball name is gnome-keyring-sharp.tar.gz?view=tar not
gnome-keyring-sharp.tar.gz 

BAD	package meets naming and versioning guidelines.
- Appears to contain an extra 1 appended to the dist tag

OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (MIT). License text included in package.
N/A	latest version is being packaged.

OK	BuildRequires are proper.
N/A	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in koji (Rawhide/x86_64).

BAD	debuginfo package looks complete.
- Debuginfo package is empty, debug package need to be disabled

OK	rpmlint is silent.
- only contains the standard bogus warnings for Mono packages

OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths, correct
scriptlets exist
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	pkgconfig files are in devel subpackage
N/A	no libtool .la droppings.
OK	not a GUI app.

Also I apologize for forgetting to do this review yesterday, I got drowned by
bugzilla spam.
Comment 2 Michel Alexandre Salim 2008-07-14 12:57:29 EDT
Updated, with the following changes:
- tarball renamed (I was using the name that wget and Firefox creates when
downloading, with the HTTP GET option not removed)
- -debuginfo package turned off

The naming convention is because this is not a stable release yet, however, I
just realized that the official recommendation is slightly different:

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages

so I've adjusted the package accordingly.


Spec URL: http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp.spec
SRPM URL:
http://salimma.fedorapeople.org/for_review/gnome/gnome-keyring-sharp-1.0.0-2.87622svn.fc9.src.rpm
Comment 4 David Nielsen 2008-07-14 13:10:24 EDT
Looks good to me. Approved
Comment 5 Michel Alexandre Salim 2008-07-14 14:55:27 EDT
New Package CVS Request
=======================
Package Name: gnome-keyring-sharp
Short Description: Mono implementation of GNOME Keyring
Owners: salimma
Branches: F-8 F-9 EL-5
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-07-14 15:39:02 EDT
cvs done.
Comment 7 Michel Alexandre Salim 2008-07-15 10:37:24 EDT
Thanks. Built for Rawhide, will build and test GNOME-Do against it and then push
it to F-9 and the rest

Note You need to log in before you can comment on or make changes to this bug.