Bug 454433 - Review Request: libvirt-cim - A CIM provider for libvirt
Summary: Review Request: libvirt-cim - A CIM provider for libvirt
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: Package Review
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Daniel Berrangé
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 188273 438555
TreeView+ depends on / blocked
 
Reported: 2008-07-08 13:47 UTC by Daniel Veillard
Modified: 2010-01-12 11:52 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-12 11:52:19 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Daniel Veillard 2008-07-08 13:47:22 UTC
Spec URL: http://veillard.com/libvirt/5.3/libvirt-cim.spec
SRPM URL: http://veillard.com/libvirt/5.3/src/libvirt-cim-0.5-1.el5.src.rpm
Description: 
Libvirt-cim is a CMPI CIM provider that implements the DMTF SVPC
virtualization model. The goal is to support most of the features
exported by libvirt itself, enabling management of multiple
platforms with a single provider.

See also https://bugzilla.redhat.com/show_bug.cgi?id=438555

Daniel

Comment 1 Daniel Riek 2008-07-15 18:25:14 UTC
Approved component for 5.3

Comment 2 Daniel Berrangé 2008-09-15 09:15:32 UTC
Original Fedora review ticket

https://bugzilla.redhat.com/show_bug.cgi?id=421871

Comment 3 Daniel Berrangé 2008-09-15 09:44:05 UTC
- A couple of places in the spec where /etc is referenced directly - replace /etc with %{_sysconfdir}

  /etc/ld.so.conf.d/libvirt-cim.conf


- Type in %install section - executes twice:


  %install
  rm -fr $RPM_BUILD_ROOT

  make DESTDIR=$RPM_BUILD_ROOT install
  make DESTDIR=$RPM_BUILD_ROOT install

   Notice the duplicated line here ^^^


All Fedora packaging & licensing guidelines passed. No fatal rpmlint errors. 

=> Approved, with suggestion that those two (fairly harmless) points above are addressed when committing to CVS.


Note You need to log in before you can comment on or make changes to this bug.