Red Hat Bugzilla – Bug 455213
[RFE] Termination script needs to handle flag requestees
Last modified: 2016-01-04 20:50:04 EST
One other area that also needs coverage in our bugzilla/rt closure script for
employees who leave redhat is to also be able to remove them from the requestee
field of any flag and change the requestee to be their managers.
FYI, the 2.18 XMLRPC API currently does not support setting requestee from the
bugzilla.updateFlags() method. We could add in that support probably easily
enough before this feature is needed.
Noura, do you know if the 3.2 Bug.update() call supports setting of
flags/requestees? I can test later and see if it does.
> Noura, do you know if the 3.2 Bug.update() call supports setting of
> flags/requestees? I can test later and see if it does.
Looking at the 3.2 code Bug.update doesn't handle the flags update basically the
flags update is handled by separate function called
Bugzilla::Flag->process($bug, $attachment, $timestamp, $vars); That function
gets the bugid or the attachment id and the time info then it reads the cgi
string and extracts the flags params from it and does the flags update,
process_bug.cgi basically calls this function to update the flags.
I guess we can use the code inside that function to do the flags/requestees
update in xmlrpc but we can not use it itself as it relies on the cgi params, I
think upstream must have work towards moving that code into Bug.update i will do
Noura is this still an issue with the current code? Did you verify that Bug.update could do this now?
Tony is looking at implementing this.
what is the status on this? Has it been moved to bz# 486898?
Red Hat Bugzilla is now using version 3.4 of the Bugzilla codebase and
therefore this bug will need to be re-verified against the new release. With
the updated code this bug may no longer be relevant or may have been fixed in
the new code. Updating bug version to 3.4.
Red Hat has now upgraded to Bugzilla 3.6 and this bug will now be reassigned to that version. It would be helpful to the Bugzilla Development Team if this bug is verified to still be an issue with the latest version. If it is no longer an issue, then feel free to close, otherwise please comment that it is still a problem and we will try to address the issue as soon as we can.
Bugzilla Development Team
Kevin: This one is for you :)
Taking since I am looking after this script now.
The upstrea bug was resolved on 2014-01-01.
(In reply to Jason McDonald from comment #13)
> The upstrea bug was resolved on 2014-01-01.
Umm, yeah. That isn't the bug I was looking for. We need to be able to change the flag types themselves, not the flags on a bug.
As well as removing the terminated account from flag requestees on existing bugs, the script should also remove terminated accounts from the list of users who receive notifications of flags requests.
(In reply to Simon Green from comment #14)
> (In reply to Jason McDonald from comment #13)
> > The upstrea bug was resolved on 2014-01-01.
> Umm, yeah. That isn't the bug I was looking for. We need to be able to
> change the flag types themselves, not the flags on a bug.
Please file a new bug upstream if one doesn't already exist.
We need to write the Web service ourself. I'll be doing it upstream, and we can backport it to 4.4 (without the REST stuff).
Eight hours to do the RPC changes, and 1 hour for the changes to the termination script.
The code has been approved upstream, but I'm not keen on backporting it. Retargeting.
This appears to have been implemented in Maitai -- see https://projects.engineering.redhat.com/browse/MAITAI-2718.