Bug 457037 - Anaconda should not allow /boot as a ext4dev partition
Anaconda should not allow /boot as a ext4dev partition
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: anaconda (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Chris Lumens
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-29 07:36 EDT by James Laska
Modified: 2013-09-02 02:25 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-29 11:03:41 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
anaconda-i386-logs.tgz (21.86 KB, application/octet-stream)
2008-07-29 07:36 EDT, James Laska
no flags Details
anaconda-ppc-logs.tgz (13.20 KB, application/octet-stream)
2008-07-29 07:36 EDT, James Laska
no flags Details
457037.patch (638 bytes, patch)
2008-07-29 08:31 EDT, James Laska
no flags Details | Diff
Expected error dialog when using applied patch (62.98 KB, image/png)
2008-07-29 08:32 EDT, James Laska
no flags Details

  None (edit)
Description James Laska 2008-07-29 07:36:19 EDT
F9 anaconda allows creation of /boot as an ext4dev partition.

According to esandeen, grub does not yet support ext4 format.  Perhaps anaconda
should not allow leaving the partitioning screen while /boot exists on ext4.

I have tested this in both i386 and ppc rawhide (see attached logs).
Comment 1 James Laska 2008-07-29 07:36:19 EDT
Created attachment 312858 [details]
anaconda-i386-logs.tgz
Comment 2 James Laska 2008-07-29 07:36:44 EDT
Created attachment 312859 [details]
anaconda-ppc-logs.tgz
Comment 3 James Laska 2008-07-29 08:31:08 EDT
Could it be a typo in partitions.py ?

diff --git a/partitions.py b/partitions.py
index 785a85d..2b0bc37 100644
--- a/partitions.py
+++ b/partitions.py
@@ -1249,7 +1249,7 @@ class Partitions:
                 # XFS causes problems as /boot. see #138673 and others
                 # gfs2 and ext4 aren't supported by grub
                 if (bootreq.fstype and
-                    bootreq.fstype.getName() in ("xfs", "gfs2", "ext4")):
+                    bootreq.fstype.getName() in ("xfs", "gfs2", "ext4dev")):
                     errors.append(_("Bootable partitions cannot be on an %s "
                                     "filesystem.")%(bootreq.fstype.getName(),))
 

Tested the above patch on rawhide ppc ... it seems to do the trick and not allow
the user to proceed past partitioning with /boot as an 'ext4dev' device.
Comment 4 James Laska 2008-07-29 08:31:55 EDT
Created attachment 312862 [details]
457037.patch
Comment 5 James Laska 2008-07-29 08:32:25 EDT
Created attachment 312863 [details]
Expected error dialog when using applied patch
Comment 6 Eric Sandeen 2008-07-29 09:17:12 EDT
ext4 & ext4dev should probably both be in the list.

-Eric
Comment 7 Chris Lumens 2008-07-29 11:03:41 EDT
Thanks for tracking this down.  I went about fixing it a different way - by
giving the filesystem type objects the ability to say whether or not they can
host /boot.

Note You need to log in before you can comment on or make changes to this bug.