Bug 457112 - [RFE] simple dedicated init script for fence_xvmd
Summary: [RFE] simple dedicated init script for fence_xvmd
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: cman
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Fabio Massimo Di Nitto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-07-29 17:35 UTC by Satoru SATOH
Modified: 2009-05-19 12:50 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-04 10:31:56 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
A sample init script for fence_xvmd (1.67 KB, text/plain)
2008-07-29 17:37 UTC, Satoru SATOH
no flags Details
An init script for fence_xvmd (1.83 KB, text/plain)
2008-08-05 03:04 UTC, Satoru SATOH
no flags Details
A patch to make fence_xvmd exitting with correct status code (378 bytes, patch)
2008-08-09 12:50 UTC, Satoru SATOH
no flags Details | Diff

Description Satoru SATOH 2008-07-29 17:35:59 UTC
Description of problem:
There are no any init scripts simply start fence_xvmd available.

As far as my understanding, it looks /etc/rc.d/init.d/cman script 
can start fence_xvmd on some conditions but it seems that it does
various thing not needed nor useful, too. 
(e.g. kvm user does not want xen stuff.)

Also, fence_xvmd has options to make it work on non-cluster/no-ccs
host and the simple dedicated init script for fence_xvmd which just 
starts it with these options must be very useful for such system, 
I think.


Version-Release number of selected component (if applicable):
cman-2.99.06-1.fc10.i386


Additional info:

I'll post a simple experimental init script for fence_xvmd looks
working well on my kvm host (no ccs and cluster).

Comment 1 Satoru SATOH 2008-07-29 17:37:56 UTC
Created attachment 312908 [details]
A sample init script for fence_xvmd

Comment 2 Satoru SATOH 2008-08-05 03:04:44 UTC
Created attachment 313419 [details]
An init script for fence_xvmd

I updated the init script to allow users to customize options for fence_xvmd by system configuration file (/etc/sysconfig/fence_xvmd).

Comment 3 Satoru SATOH 2008-08-09 12:50:20 UTC
Created attachment 313874 [details]
A patch to make fence_xvmd exitting with correct status code

When fence_xvmd exits, it always returns 0 as the status code even if
there were any errors occured. This is commonly not good for init 
scripts.

The tiny patch attached fixes this problem.

This is for git (master) HEAD but still applicable to cman-2.99.06 
and cman-2.0.60-6 (tag: fc10).

Comment 4 Satoru SATOH 2008-09-09 02:38:39 UTC
Here is a configuration example:

--------------------------------- /etc/sysconfig/fence_xvmd
# Make fence_xvmd only listen on xenbr1
# EXTRA_DAEMON_OPTS="-I xenbr1"

# Make fence_xvmd only listen on virbr0 and use ipv6
EXTRA_DAEMON_OPTS="-I virbr0 -i ipv6"
-----------------------------------------------------------

Comment 5 Fabio Massimo Di Nitto 2009-01-27 09:58:03 UTC
Hi,

thanks for the whole submission, I'll take care to put it into the different components. It will be rawhide and later on F10.

Thanks
Fabio

Comment 6 Lon Hohberger 2009-03-27 13:57:07 UTC
Wouldn't it be simpler to just change the 'which xm' line to 'which virsh' ?

fence_xvmd requires libvirt, but not Xen (any more)

Comment 7 Fabio Massimo Di Nitto 2009-05-04 10:31:56 UTC
We addressed the issues in a lot simpler way in our current git repo and the fix will be part of cluster 3.0.0.rc2.

By specifing -L to FENCE_XVMD_OPTS, the cman init script will now only starts fence_xvmd in standalone mode, without starting anything else.

Fabio


Note You need to log in before you can comment on or make changes to this bug.