Bug 457889 - RFE: gallery2: consider switching to using system Smarty if possible
RFE: gallery2: consider switching to using system Smarty if possible
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: gallery2 (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: John Berninger
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-05 04:46 EDT by Tomas Hoger
Modified: 2008-12-18 15:38 EST (History)
1 user (show)

See Also:
Fixed In Version: 2.2.4-3
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-12-18 15:38:30 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Tomas Hoger 2008-08-05 04:46:55 EDT
Description of problem:
Current gallery2 packages contain a private copy of Smarty, which is also
packaged in Fedora as php-Smarty.  Any bug (or security issue) in Smarty now
requires update of both php-Smarty and all applications having own copy.

Please investigate if gallery2 can be used with system Smarty, or depends on some project-specific customizations.

Possible straight forward way to use system smarty is to do something like:
  rm -rf /usr/share/gallery2/lib/smarty
  ln -s /usr/share/php/Smarty/ /usr/share/gallery2/lib/smarty

+ depends on php-Smarty (this should already be done).

Ideally, there may be a way to use system smarty without exposing it in the
directory served by web server, as was done in php-pear-PhpDocumentor:
http://cvs.fedoraproject.org/viewcvs/rpms/php-pear-PhpDocumentor/devel/php-pear-PhpDocumentor.spec?r1=1.4&r2=1.5


Version-Release number of selected component (if applicable):
gallery2-2.2.5-1.fc9


Additional info:
The attempt was already made to do this change:
http://cvs.fedoraproject.org/viewcvs/rpms/gallery2/devel/gallery2.spec?r1=1.14&r2=1.15
However, it spec file tries to remove Smarty directory, instead of smarty, and local copy is still shipped (php-Smarty dependency seems redundant).

Other libraries with local copies in lib/ may also have system package
counterpart.
Comment 1 John Berninger 2008-08-05 07:32:48 EDT
This was done in version 2.2.4-3 (three releases ago), per the RPM changelog of the package.
Comment 2 Tomas Hoger 2008-08-05 08:43:51 EDT
(In reply to comment #1)
> This was done in version 2.2.4-3 (three releases ago), per the RPM changelog of
> the package.

John, you did not read the bug description very carefully, right?  Quoting myself:

Additional info:
The attempt was already made to do this change:
http://cvs.fedoraproject.org/viewcvs/rpms/gallery2/devel/gallery2.spec?r1=1.14&r2=1.15
However, it spec file tries to remove Smarty directory, instead of smarty, and
local copy is still shipped (php-Smarty dependency seems redundant).

That's the change done in 2.2.4-3 and I described why it did not solve the issue.
Comment 3 Gwyn Ciesla 2008-12-18 13:45:44 EST
Working on a correction.
Comment 4 Gwyn Ciesla 2008-12-18 15:38:30 EST
Fixed in rawhide.

Note You need to log in before you can comment on or make changes to this bug.