Bug 458026 - In-Reply-To in notification emails changed format; threading broke
In-Reply-To in notification emails changed format; threading broke
Status: CLOSED NEXTRELEASE
Product: Bugzilla
Classification: Community
Component: Bugzilla General (Show other bugs)
devel
All Linux
medium Severity medium (vote)
: ---
: ---
Assigned To: David Lawrence
:
Depends On:
Blocks: 1318162
  Show dependency treegraph
 
Reported: 2008-08-06 03:00 EDT by Mark McLoughlin
Modified: 2016-03-16 04:10 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1318162 (view as bug list)
Environment:
Last Closed: 2008-08-06 12:31:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to fix domain name in the in-reply-to mail header (v1) (983 bytes, patch)
2008-08-06 11:38 EDT, David Lawrence
nelhawar: review+
Details | Diff

  None (edit)
Description Mark McLoughlin 2008-08-06 03:00:25 EDT
Not worth fixing unless easy to fix, but the email headers used to contain:

  In-Reply-To: <bug-446214-196610@bugzilla.redhat.com>

but now contain

  In-Reply-To: <bug-446214-196610@https.bugzilla.redhat.com/>

so new email threads have been created.

It'd be nice to go back to the old format again
Comment 1 David Lawrence 2008-08-06 11:04:40 EDT
Verified this is indeed broken. Taking and will fix in the next update.
Comment 2 David Lawrence 2008-08-06 11:38:37 EDT
Created attachment 313587 [details]
Patch to fix domain name in the in-reply-to mail header (v1)

Patch attached for review to fix the domain name that is in reply to header.
In upstream bugzilla they add the http(s) to the domain name for reasons I am not sure. In 2.18 we had bugzilla.redhat.com as the domain name hard coded into the email template.

The patch hacks the BugMail.pm code to remove the https from the domain name and the trailing slash so it better matches 2.18 behaviour.

Please review

Dave
Comment 3 Noura El hawary 2008-08-06 12:22:52 EDT
Comment on attachment 313587 [details]
Patch to fix domain name in the in-reply-to mail header (v1)

looks Good Dave, I saw it works fine on bz-web2.

Noura
Comment 4 David Lawrence 2008-08-06 12:31:39 EDT
Thanks Noura. Checking into CVS and will be in the next update.

Note You need to log in before you can comment on or make changes to this bug.