Bug 458538 - bug in patch 12: eclipse-launcher-set-install-dir-and-shared-config.patch
Summary: bug in patch 12: eclipse-launcher-set-install-dir-and-shared-config.patch
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-09 14:18 UTC by Igor Vlasenko
Modified: 2008-08-11 21:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-11 21:56:15 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
redesigned and cleaned up patch (w/o -g part) (1.36 KB, patch)
2008-08-09 14:18 UTC, Igor Vlasenko 		no flags Details | Diff
redesigned and cleaned up patch (-g part) (781 bytes, patch)
2008-08-09 14:19 UTC, Igor Vlasenko 		no flags Details | Diff
View All

Description Igor Vlasenko 2008-08-09 14:18:12 UTC 
Created attachment 313878 [details]
redesigned and cleaned up patch (w/o -g part)

Description of problem:
patch contains a line which cause string overflow
the problematic place is here:
< +     programDir = malloc( (_tcslen( temp + 1 )) * sizeof(_TCHAR) );
---
> +     programDir = malloc( (_tcslen( temp ) + 1) * sizeof(_TCHAR) );

Version-Release number of selected component (if applicable):
eclipse-3.3.2-12
Comment 1 Igor Vlasenko 2008-08-09 14:19:32 UTC 
Created attachment 313879 [details]
redesigned and cleaned up patch (-g part)
Comment 2 Andrew Overholt 2008-08-11 15:25:21 UTC 
Hi Igor,

Thanks for updating the patch.  Unfortunately, it's no longer needed.  I'm sorry if this wasted your time at all :(

Andrew
Comment 3 Igor Vlasenko 2008-08-11 21:56:15 UTC 
fine
Note You need to log in before you can comment on or make changes to this bug.