Spec URL: http://kushal.fedorapeople.org/translation-filter.spec SRPM URL: http://kushal.fedorapeople.org/translation-filter-0.0.2-1.fc9.noarch.rpm Description: A l10n file filter to check translations
Oops, made mistake in link Correct ones are Spec URL: http://kushal.fedorapeople.org/translation-filter.spec SRPM URL: http://kushal.fedorapeople.org/translation-filter-0.0.2-1.fc9.src.rpm
Need some work: 1)Remove unnecessary line from SPEC %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} 2) Remove docs/LICENSE from SPEC 3) build failed with error /var/tmp/rpm-tmp.bbjMqY: line 31: desktop-file-install: command not found ==> Add desktop-file-install as BR
(In reply to comment #2) > Need some work: > 1)Remove unnecessary line from SPEC > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} > > 2) Remove docs/LICENSE from SPEC > > 3) build failed with error > /var/tmp/rpm-tmp.bbjMqY: line 31: desktop-file-install: command not found > ==> Add desktop-file-install as BR oops. it should be BR: desktop-file-utils 4) also license looks to me GPLv2
(In reply to comment #3) > (In reply to comment #2) > > Need some work: > > 1)Remove unnecessary line from SPEC > > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from > > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} > > > > 2) Remove docs/LICENSE from SPEC > > > > 3) build failed with error > > /var/tmp/rpm-tmp.bbjMqY: line 31: desktop-file-install: command not found > > ==> Add desktop-file-install as BR > > oops. it should be BR: desktop-file-utils > > 4) also license looks to me GPLv2 Fixed Spec URL:http://kushal.fedorapeople.org/translation-filter.spec SRPM URL: http://kushal.fedorapeople.org/translation-filter-0.0.2-2.fc9.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=769876 + rpmlint is silent for SRPM and for RPM. + source files match upstream. ca6b4bf23f0745e6717905b3d62b32b0 translation-filter-0.0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + GUI app. + Package installed correctly. APPROVED.
New Package CVS Request ======================= Package Name: translation-filter Short Description: A l10n file filter Owners: kushal Branches: F-9 EL-5 InitialCC: kushal Cvsextras Commits: yes
cvs done.
translation-filter-0.0.2-2.fc9 has been submitted as an update for Fedora 9
translation-filter-0.0.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.