Spec URL: http://holtmann.fedorapeople.org/packages/libgdbus.spec SRPM URL: http://holtmann.fedorapeople.org/packages/libgdbus-0.1-1.fc9.src.rpm Description: libgdbus is a helper library for D-Bus integration with GLib
Suggestions 1) remove following from %files %{_libdir}/*.a see http://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries 2) Your build section should look like this %configure --disable-static make %{?_smp_mflags} 3) Add "Requires: pkgconfig" to devel package From Review Guidelines you can see - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). 4) rpmlint complain that libgdbus.i386: E: zero-length /usr/share/doc/libgdbus-0.1/NEWS ==> Remove NEWS from %docs 5) you should drop following line from SPEC /sbin/ldconfig -n $RPM_BUILD_ROOT/%{_libdir}
Thanks for the review. Spec URL: http://holtmann.fedorapeople.org/packages/libgdbus.spec SRPM URL: http://holtmann.fedorapeople.org/packages/libgdbus-0.1-2.fc9.src.rpm Description: libgdbus is a helper library for D-Bus integration with GLib
Reassigning back to Parag, the "Review request" bug should be assigned to reviewer during its whole life. And one note - you should remove the explicit "Requires: glib2 dbus" as such dependencies are created automagically during the build process.
aah. All I can see about you is that this is your first package submission to Fedora. If not then tell me which packages you are/was maintaining. You should look first http://fedoraproject.org/wiki/Package_Review_Process You actually removed me from official review process. Have you done enough package reviews before? I see that you are already member of packager group. Thanks danny for your comment.
Fixed the Requires mistake. Spec URL: http://holtmann.fedorapeople.org/packages/libgdbus.spec SRPM URL: http://holtmann.fedorapeople.org/packages/libgdbus-0.1-3.fc9.src.rpm Description: libgdbus is a helper library for D-Bus integration with GLib
1) I think you should also keep timestamps using following command make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 2) I see there is no documentation/APIs for this library but there are some example files in test directory. you should also add them to %doc of -devel package. Don't include irrelevant files from test/* to %doc 3) Drop INSTALL from %doc as its really of no use. BTW, Is this your first package submission?
any updates here?
Will Close this as NOTABUG by this Thursday if updates are not submitted.
marking as DEADREVIEW as no updates from submitter.