Bug 459886 - Review Request: rubygem-main - A class factory and dsl for generating command line programs real quick
Summary: Review Request: rubygem-main - A class factory and dsl for generating command...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: S.A. Hartsuiker
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-23 17:56 UTC by Jeroen van Meeuwen
Modified: 2008-10-30 12:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-30 12:47:57 UTC
Type: ---
Embargoed:
s.a.hartsuiker: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Jeroen van Meeuwen 2008-08-23 17:56:03 UTC
Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-main.spec
SRPM URL: http://www.kanarip.com/custom/f10/SRPMS/rubygem-main-2.8.2-1.fc10.src.rpm
Description: A class factory and dsl for generating command line programs real quick

rpmlint is silent

koji scratch builds:

- f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=781425
- f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=781427
- f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=781429

Comment 1 Jeroen van Meeuwen 2008-09-08 14:16:55 UTC
Added the ruby(abi) = 1.8 requirement;

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-main.spec
New SRPM: http://www.kanarip.com/custom/f10/SRPMS/rubygem-main-2.8.2-2.fc10.src.rpm

Comment 2 S.A. Hartsuiker 2008-10-22 18:43:54 UTC
RPM Lint: quiet
Package name: ok
Spec file: ok
License: GPLv2+ or Ruby
Actual License: Ruby
%doc License: n/a
Spec file language: ok
Spec file readable: ok
Upstream source vs. used tarball: ok
Compile and Build:
 - F-8: ok
 - F-9: ok
 - F-10: ok
 - rawhide: ok
 - EL-5: n/a

Applicable Package Guidelines: ok

Locales: n/a
Shared libs: n/a

Relocatable: no
Directory and file ownership: ok
No duplicate files in %files: ok
File Permissions: ok
Macro usage: ok
Code vs. Content: ok
(Large) Documentation: n/a
%doc affecting runtime: n/a
Header files in -devel package: n/a
Static Libraries in -static package: n/a
pkgconfig Requires: n/a
Library files: n/a
Devel requires base package: n/a
.la libtool archives: n/a
Duplicate ownership of files/directories: ok
Remove BuildRoot: yes
UTF-8 filenames: ok

I see no mention of GPLv2+ anywhere in the code/files.
And per http://codeforpeople.com/lib/license.txt the license should be Ruby.

Fix the license tag and I can approve the package.

Comment 4 S.A. Hartsuiker 2008-10-25 22:45:22 UTC
the license was fixed, so package APPROVED

Comment 5 Jeroen van Meeuwen 2008-10-25 23:56:41 UTC
New Package CVS Request
=======================
Package Name: rubygem-main
Short Description: A class factory and dsl for generating command line programs real quick
Owners: kanarip
Branches: EL-4 EL-5 F-8 F-9 devel
InitialCC:

Comment 6 Dennis Gilmore 2008-10-27 04:24:56 UTC
CVS Done

Comment 7 Fedora Update System 2008-10-27 22:40:49 UTC
rubygem-main-2.8.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/rubygem-main-2.8.2-3.fc9

Comment 8 Fedora Update System 2008-10-27 23:47:56 UTC
rubygem-main-2.8.2-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/rubygem-main-2.8.2-3.fc8

Comment 9 Fedora Update System 2008-10-30 12:47:54 UTC
rubygem-main-2.8.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-10-30 12:51:18 UTC
rubygem-main-2.8.2-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.