Bug 461273 - Review Request: libassuan - GnuPG IPC library
Summary: Review Request: libassuan - GnuPG IPC library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: Package Review
Version: 5.4
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Miloslav Trmač
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 188273 484192 484236
TreeView+ depends on / blocked
 
Reported: 2008-09-05 14:02 UTC by Peter Vrabec
Modified: 2009-04-01 09:09 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-01 09:09:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Peter Vrabec 2008-09-05 14:02:17 UTC
Spec URL: http://people.redhat.com/pvrabec/gnupg2/libassuan.spec
SRPM URL: http://people.redhat.com/pvrabec/gnupg2/libassuan-1.0.4-2.src.rpm
Description: 
This is the IPC library used by GnuPG 2, GPGME and a few other packages.

Comment 1 Miloslav Trmač 2008-09-18 15:33:18 UTC
rpmlint: OK

blocker: the package contains GPLv3+ -licensed documentation, the License: field must reflect that (see https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios )

blocker: COPYING must be shipped in %doc in addition to COPYING.LIB

blocker: Package should Requires: automake for /usr/share/aclocal directory ownership

blocker: install-info --delete should be run in %preun, not in %postun

note: BuildRequires: gawk is not necessary - but does not hurt anything

Comment 3 Miloslav Trmač 2008-09-22 20:07:42 UTC
That package looks OK - except that you have removed "BuildRequires: pth-devel".  Was that intentional?  Or did you perhaps intend to remove "BuildRequires: gawk" instead?

Comment 4 Peter Vrabec 2009-01-16 16:52:04 UTC
update!
Spec URL: http://people.redhat.com/pvrabec/gnupg2/libassuan.spec
SRPM URL: http://people.redhat.com/pvrabec/gnupg2/libassuan-1.0.4-4.fc9.src.rpm

I'm afraid that was a mistake. :)

Comment 5 Miloslav Trmač 2009-01-19 23:36:48 UTC
Thanks, approved.

Comment 6 Peter Vrabec 2009-03-27 13:02:17 UTC
libassuan-1.0.4-4.el5 was built
https://brewweb.devel.redhat.com/buildinfo?buildID=83207


Note You need to log in before you can comment on or make changes to this bug.