Red Hat Bugzilla – Bug 461425
Review Request: daap-sharp - DAAP client library for Mono
Last modified: 2009-03-24 15:23:51 EDT
This is a re-review of an orphaned package.
Spec URL: http://znark.com/fedora/daap-sharp.spec
SRPM URL: http://znark.com/fedora/daap-sharp-0.3.5-2.fc10.src.rpm
Description: daap-sharp is a DAAP (Digial Audio Access Protocol) implementation.
It is used by Apple's iTunes software to share music.
Seems that it's already in Fedora
(In reply to comment #1)
> Seems that it's already in Fedora
It was in Fedora. It got orphaned and removed around Fedora 7. It needs a re-review to be restored.
Straightforward review, since the package has already been approved, so these are just clean-up requests.
daap-sharp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10)
Easiest fix is to open the file in Emacs, select all, then M-x untabify
Package builds OK, but on my system that has monodoc installed, it generates some files that are currently unpackaged:
RPM build errors:
Installed (but unpackaged) file(s) found:
These won't be generated by Koji since monodoc is not installed there, but would you consider adding a BR and packaging them, perhaps in a -doc subpackage?
Fails on ppc64, not sure if it's transient or not, but you might want to take a look. If it's replicable you might want to ExcludeArch ppc64 and file a tracking bug (or reuse the Mono ppc64 tracking bug)
Closing due to lack of response