Red Hat Bugzilla – Bug 462104
Review Request: cryptopp - Public domain C++ class library of cryptographic schemes
Last modified: 2011-07-11 23:35:53 EDT
Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/amule/cryptopp.spec
SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/amule/cryptopp-5.5.2-1.fc9.src.rpm
Crypto++ Library is a free C++ class library of cryptographic schemes.
See http://www.cryptopp.com/ for a list of supported algorithms.
The potentially patented code was removed (one algorithm), see the "License" section of http://www.cryptopp.com/ for details.
Can you recreate cryptopp-5.5.2-gcc4.3.patch?
It fails with the latest version of rpm on rawhide:
+ echo 'Patch #1 (cryptopp-5.5.2-gcc4.3.patch):'
Patch #1 (cryptopp-5.5.2-gcc4.3.patch):
+ /bin/cat /home/ruben/rpmbuild/SOURCES/cryptopp-5.5.2-gcc4.3.patch
+ /usr/bin/patch -s -p1 -b --suffix .gcc4.3 --fuzz=0
1 out of 1 hunk FAILED -- saving rejects to file misc.h.rej
error: Bad exit status from /var/tmp/rpm-tmp.ywiqRm (%prep)
OK, here's the new version :
Thanks, I'm reviewing it now.
FYI: There is a review request for this at RPMFusion, maybe it is not acceptable for Fedora, because iirc RPMFusion does not provide packages, that are suitable for Fedora:
-Sources need to be repackaged (using a script is better). So we don't redistribute the patented code.
-You can leave sse2 on x86_64 (worksforme) and every x86_64 cpu have sse2.
-Prevent timestramp change on make install for headers by using "install -p"
Thanks Nicolas, here's the new version :
You have assigned yourself to the bug.
What's hold the review ?
My build machine seems to have too little memory to build cryptopp, the build has been running for ages.
Are you willing to take over?
Interesting. Which machine do you have ?
Does a koji --scratch build also failed for a given Fedora version ?
I have a virtual machine at Slicehost with 256MB of ram. This isn't enough to build cryptopp with.
In the meantime I've got hold of an other machine, and did a successful build:
Review for release 3.fc9:
* RPM name is OK
* Builds fine in mock
Aurelien, there's one small rpmlint warning:
cryptopp.src: W: strange-permission cryptopp-remove-patented-code.sh 0775
This package is APPROVED, don't forget to fix that warning when checking in.
New Package CVS Request
Package Name: cryptopp
Short Description: Public domain C++ class library of cryptographic schemes
Branches: F-8 F-9
cryptopp-5.5.2-3.fc9 has been submitted as an update for Fedora 9.
cryptopp-5.5.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request
Package Name: cryptopp
New Branches: el6
Owners: sundaram nucleo
Git done (by process-git-requests).