Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-uk.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-uk-1.5.0-1.fc9.src.rpm Description: Ukrainian hunspell dictionary
I don't understand here usage of Source1 and Source2 from hunspell-uk.spec
It doesn't make any sense, I've copied and pasted from the wrong hunspell .spec template this time :-), try... http://people.redhat.com/caolanm/hunspell/hunspell-uk.spec http://people.redhat.com/caolanm/hunspell/hunspell-uk-1.5.0-2.fc9.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=829727 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 948964c6544fb408ce8cd1c55ba3f92b myspell-uk_UA-1.5.0.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: hunspell-uk Short Description: Ukrainian hunspell dictionaries Owners: caolanm Branches: InitialCC:
cvs done.