Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-ve.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-ve-0.20060706-1.fc9.src.rpm Description: Vietnamese spellchecking dictionaries
Hi, I am not sure whether I should close this as duplicate or you need to change package name. I can see this package name already taken for Venda hunspell dictionaries. See https://bugzilla.redhat.com/show_bug.cgi?id=462257
Sigh, I'm going blind. Those are of course the *Venda* ones, these are the Vietnamese ones that I had in mind. http://people.redhat.com/caolanm/hunspell/hunspell-vi.spec http://people.redhat.com/caolanm/hunspell/hunspell-vi-0.20080604-1.fc9.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=835683 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 4145805858071f0c5f3b1201b4ceb91e vi_VN.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: hunspell-vi Short Description: Vietnamese hunspell dictionaries Owners: caolanm Branches: InitialCC:
cvs done