Red Hat Bugzilla – Bug 464402
Review-Request: numptyphysics - A crayon-drawing based physics puzzle game
Last modified: 2008-09-30 04:11:05 EDT
Harness gravity with your crayon and set about creating blocks, ramps,
levers, pulleys and whatever else you fancy to get the little red thing to
the little yellow thing.
+ package meets naming and versioning guidelines
+ specfile is properly named, is cleanly written and uses macros consistently
+ dist tag is present.
+ license field matches the actual license
+ license is open source-compatible
+ license text not included upstream
+ %clean is present.
+ package builds in mock (f8, rawhide)
+ package installs properly (f8)
+ rpmlint output is sane
+ desktop file install properly
- use %doc to include documentation
- SDL-devel dependency is fetched by SDL_image-devel, it's safe to remove
- desktop file is not (fully) valid:
./numptyphysics.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
Thanks for review. New package:
(In reply to comment #1)
> - use %doc to include documentation
There's no documentation in the source tree.
> - SDL-devel dependency is fetched by SDL_image-devel, it's safe to remove
> - desktop file is not (fully) valid:
> ./numptyphysics.desktop: warning: key "Encoding" in group "Desktop Entry" is
Right, that's windows documentation :)
New Package CVS Request
Package Name: numptyphysics
Short Description: A crayon-drawing based physics puzzle game
Branches: F-9 EL-5
Thanks Huzaifa; imported and built.