Bug 465186 - pam_mysql's use_first_pass and try_first_pass are broken
Summary: pam_mysql's use_first_pass and try_first_pass are broken
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: pam_mysql
Version: 11
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul P Komkoff Jr
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-01 23:26 UTC by Philippe Troin
Modified: 2010-06-28 10:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-28 10:45:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch fixing the problem. (901 bytes, patch)
2008-10-01 23:30 UTC, Philippe Troin
no flags Details | Diff

Description Philippe Troin 2008-10-01 23:26:44 UTC
Description of problem:

I use pam_mysql for a service that queries pam_mysql first, then tries to authenticate against the regular pam_unix module.

My pam configuration is thus:

  /etc/pam.d/foo:

    auth sufficient pam_mysql.so XXXXX try_first_pass=false use_first_pass=false
    auth required   pam_unix.so  XXXXX try_first_pass=false use_first_pass=true

The idea is that the password should only be asked once, by the pam_mysql module and should be passed down to the other modules.

Now if the database specified in pam_mysql is down, the password is never asked and authentication against pam_unix always fails (even for a valid UNIX account).

Version-Release number of selected component (if applicable):

pam_mysql-0.7-0.4.rc1.fc8.i386
pam-0.99.8.1-17.1.fc8.i386

How reproducible:

Always.

Steps to Reproduce:
1. Create a /etc/pam.d/foo with the following lines:

     auth sufficient pam_mysql.so host=/path/to/file/that/does/not/exists try_first_pass=false use_first_pass=false
     auth required pam_unix.so use_first_pass

   Note that I am intentionally asking pam_mysql to point to a DB that is not there.

2. Try to login against the 'foo' pam service.
  
Actual results:

Password is never asked.

Expected results:

Password should be asked, and pam_unix should do its job even if pam_mysql cannot.

Comment 1 Philippe Troin 2008-10-01 23:30:34 UTC
Created attachment 319180 [details]
Patch fixing the problem.

The attached patch fixes the problem.

The PAM_AUTHTOK item is always set, even if pam_mysql fails to connect to its DB.

Additionally, when use_first_pass or try_first_pass are true, and there is no password provided, then the DB is not even queried because the password check is always going to fail.

Phil.

Comment 2 Bug Zapper 2008-11-26 11:12:16 UTC
This message is a reminder that Fedora 8 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 8.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '8'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 8's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 8 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Bug Zapper 2009-01-09 07:53:07 UTC
Fedora 8 changed to end-of-life (EOL) status on 2009-01-07. Fedora 8 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 4 Bug Zapper 2009-06-09 09:45:03 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 5 Bug Zapper 2010-04-27 12:15:25 UTC
This message is a reminder that Fedora 11 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 11.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '11'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 11's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 11 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Bug Zapper 2010-06-28 10:45:10 UTC
Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.