Spec URL: http://o5za5.cz/fedora/perl-Net-Daemon.spec SRPM URL: http://o5za5.cz/fedora/perl-Net-Daemon-0.44-2.fc9.src.rpm Description: Net::Daemon is an abstract base class for implementing portable server applications in a very simple way. The module is designed for Perl 5.006 (and higher) and ithreads, but can work with fork() and Perl 5.004. The Net::Daemon class offers methods for the most common tasks a daemon needs: Starting up, logging, accepting clients, authorization, restricting its own environment for security and doing the true work. You only have to override those methods that aren't appropriate for you, but typically inheriting will safe you a lot of work anyways.
I am very curious: why did you add Requires: perl >= 5.6.0 if the description says The module is designed for Perl 5.006 (and higher) and ithreads, but can work with fork() and Perl 5.004. ?
I changed it to fedora perl template default: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version) as in other perl packages. Spec URL: http://o5za5.cz/fedora/perl-Net-Daemon.spec SRPM URL: http://o5za5.cz/fedora/perl-Net-Daemon-0.44-3.fc9.src.rpm
You forgot to add the corresponding changelog entry. And rpmlint is not happy at all: perl-Net-Daemon.src: E: description-line-too-long Net::Daemon is an abstract base class for implementing portable server applications in a very simple way. The module is designed for Perl 5.006 and ithreads (and higher), but can work with fork() and Perl 5.004. perl-Net-Daemon.src: E: description-line-too-long The Net::Daemon class offers methods for the most common tasks a daemon needs: Starting up, logging, accepting clients, authorization, restricting its own environment for security and doing the true work. You only have to override those methods that aren't appropriate for you, but typically inheriting will safe you a lot of work anyways. --> Please trim the lines at 80 chars perl-Net-Daemon.src: W: invalid-license GPL perl-Net-Daemon.src: W: invalid-license Artistic --> please replace with "GPL+ or Artistic"
Added Changelogs entries, License replaced, lines trimed. Spec URL: http://o5za5.cz/fedora/perl-Net-Daemon.spec SRPM URL: http://o5za5.cz/fedora/perl-Net-Daemon-0.44-4.fc9.src.rpm
I am far from being a perl guy, but I find odd that almost all tests are disabled / removed. Are you _sure_ this is a desired behaviour ? During my programming classes I was taught that failing tests indicate a problem which should be fixed.
Tests work fine locally. But they try to open INET/UNIX socket, bind to a port and connect. And if I try to build this package with Koji, tests fail on Unexpected return from Bind(). and also: Cannot connect: Connection refused at t/ithreadm.t line 63.
Indeed, all tests worked locally and, according to the advices I have received via IRC, not running the tests during koji build is fine. I'll do a full review soon, but could you please consider wrapping the disabled tests in a conditional block, so that one could do a local build in the form rpmbuild --rebuild "with tests" perl-Net-Daemon ? It's not a blocker, but I think it is more elegant than blindly deleting them and it only takes very few additional lines in the spec.
OK. I changed it. Now if you want to call network tests use: rpmbuild --rebuild --with network-tests ... Spec URL: http://o5za5.cz/fedora/perl-Net-Daemon.spec SRPM URL: http://o5za5.cz/fedora/perl-Net-Daemon-0.44-5.fc9.src.rpm
Excellent, all is OK. Mind that the correct switch is --with network_tests not network-tests, please modify the newest changelog entry accordingly. APPROVED
fixed
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic (same as perl) [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 15c1dc7744079a2c283de4129652b7c9b5024f12 Net-Daemon-0.43.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. Not tested , but it's a standard perl module and should work anywhere [?] Package functions as described. --> make test is OK [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane.
New Package CVS Request ======================= Package Name: perl-Net-Daemon Short Description: Perl extension for portable daemons Owners: plautrba Branches: F-8 F-9 F-10 InitialCC:
cvs done.
perl-Net-Daemon-0.44-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Net-Daemon-0.44-5.fc9
perl-Net-Daemon-0.44-5.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/perl-Net-Daemon-0.44-5.fc8
perl-Net-Daemon-0.44-5.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-Daemon'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-9098
perl-Net-Daemon-0.44-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-Net-Daemon-0.44-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Petr: I'll be very thankful if this was in EPEL-5 as well. Could you please request an EL-5 branch (I'd gladly do that if you have a reason for not maintaining it there). Thanks!
Package Change Request ====================== Package Name: perl-Net-Daemon New Branches: EL-4 EL-5 Owners: plautrba
perl-Net-Daemon-0.44-7.el5.noarch.rpm and perl-Net-Daemon-0.44-7.el4.noarch.rpm were pushed to epel-testing