Bug 466407 - patch rpm-spec-mode.el to look only for fields at beginning of line
Summary: patch rpm-spec-mode.el to look only for fields at beginning of line
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: emacs
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Novotny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-10 04:51 UTC by Jens Petersen
Modified: 2008-11-11 03:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-11 03:54:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
emacs-rpm-mode-field.patch (652 bytes, patch)
2008-10-10 04:51 UTC, Jens Petersen
no flags Details | Diff

Description Jens Petersen 2008-10-10 04:51:11 UTC
Created attachment 319972 [details]
emacs-rpm-mode-field.patch

Description of problem:
Here is a small patch to rpm-spec-mode to make it look for fields at the beginnings of lines.
Otherwise it may catch macro definitions with the field name in them instead of the actual field.

Steps to Reproduce:
1. Open ibus.spec from fedora package cvs
2. Add a changelog entry (C-c C-e)
  
Actual results:
* Fri Oct 10 2008 Joe Packager <packager> - %define gtk_binary_version %(pkg-config  --variable=gtk_binary_version gtk+-2.0)}-4
- 

Expected results:
* Fri Oct 10 2008 Joe Packager <packager> - 0.1.1.20081006-4
- 

Additional info:
I sent this patch upstream to scop too already but cc'ing him here too if he has comments.

Comment 1 Ville Skyttä 2008-10-10 16:14:57 UTC
The patch is good, and applied now in XEmacs CVS, along with a similar fix to rpm-increase-release-with-macros (rpm-spec-mode-version 0.12.2x).

Comment 2 Jens Petersen 2008-11-08 07:56:01 UTC
Should get fixed in emacs-22.3-1.fc11.


Note You need to log in before you can comment on or make changes to this bug.