Bug 466656 - grip breaks utf-8 sequences up when writing xmcd CD database file
Summary: grip breaks utf-8 sequences up when writing xmcd CD database file
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: grip
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-12 10:13 UTC by Sjoerd Mullender
Modified: 2008-12-07 04:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-07 04:15:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Sjoerd Mullender 2008-10-12 10:13:49 UTC
Description of problem:
When a track title contains non-ASCII UTF-8 characters (i.e. ones that are represented by more than one byte), grip may break those sequences into two when they occur at the "right" place, making the resulting file non-UTF-8 compliant.
Presumably this bug also occurs in all other fields.

Version-Release number of selected component (if applicable):
grip-3.2.0-22.fc9.x86_64

How reproducible:
100% if you put the UTF-8 sequence at the right location in the track title

Steps to Reproduce:
1.rip a CD and fill in track 1 with (e.g.)
BWV 135 "Ach Herr, mich armen Sünder": Coro: "Ach Herr, mich armen Sünder"
2.then click on the Save disc info button.
  
Actual results:
the track title in the saved file looks like
TTITLE0=BWV 135 "Ach Herr, mich armen Sünder": Coro: "Ach Herr, mich armen S
TTITLE0=�nder"

In this case it looks like the first byte of the UTF-8 sequence got lost.  The second line starts with \274 which is the second byte of the UTF-8 sequence for u+diaeresis (\303\274).  I have also seen that the first byte of the sequence is on the first TTITLE line and the second byte on the second line.

Expected results:
Something like:
TTITLE0=BWV 135 "Ach Herr, mich armen Sünder": Coro: "Ach Herr, mich armen S
TTITLE0=ünder"


Additional info:
My system LANG is en_US.utf8.

Comment 1 Adrian Reber 2008-10-27 11:39:30 UTC
I was able to verify it. I will look into it.

Comment 2 Adrian Reber 2008-11-10 06:42:42 UTC
I think I have a fix. Could you test it?

Comment 3 Sjoerd Mullender 2008-11-10 21:21:05 UTC
Where can I find the fixed version?  I found grip-3.2.0-24.fc9.x86_64.rpm on Koji, but that doesn't fix it.

Comment 4 Adrian Reber 2008-11-10 21:34:39 UTC
I have just requested a build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=925289

Should be available soon.

Comment 5 Sjoerd Mullender 2008-11-10 22:21:28 UTC
It looks good.  I played around a little with where I put the non-ASCII characters, and wherever I put them, the line was broken at character boundaries as opposed to random byte positions.

Comment 6 Adrian Reber 2008-11-11 07:48:15 UTC
Thanks for your testing. I will soon push updates to all branches.

Comment 7 Fedora Update System 2008-11-15 22:21:59 UTC
grip-3.2.0-25.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/grip-3.2.0-25.fc10

Comment 8 Fedora Update System 2008-11-15 22:22:49 UTC
grip-3.2.0-25.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/grip-3.2.0-25.fc9

Comment 9 Fedora Update System 2008-11-15 22:23:34 UTC
grip-3.2.0-25.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/grip-3.2.0-25.fc8

Comment 10 Fedora Update System 2008-11-19 14:46:45 UTC
grip-3.2.0-25.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update grip'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9701

Comment 11 Fedora Update System 2008-11-19 14:52:52 UTC
grip-3.2.0-25.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update grip'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-9752

Comment 12 Fedora Update System 2008-11-22 16:59:21 UTC
grip-3.2.0-25.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update grip'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10000

Comment 13 Fedora Update System 2008-12-07 04:15:00 UTC
grip-3.2.0-25.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2008-12-07 04:22:43 UTC
grip-3.2.0-25.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2008-12-07 04:31:08 UTC
grip-3.2.0-25.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.