Bug 467290 - Review Request: qpackagekit - renamed from libpackagekit-qt
Summary: Review Request: qpackagekit - renamed from libpackagekit-qt
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-16 17:45 UTC by Steven M. Parrish
Modified: 2009-01-09 15:03 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-09 15:03:42 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Steven M. Parrish 2008-10-16 17:45:06 UTC
Spec URL: http://tuxbrewr.fedorapeople.org/qpackagekit/
SRPM URL: http://tuxbrewr.fedorapeople.org/qpackagekit/

Description: Qt bindings for kpackagekit.

build logs here https://koji.fedoraproject.org/koji/taskinfo?taskID=884422

Comment 1 Rex Dieter 2008-10-16 18:29:58 UTC
fyi, just a quick re-review, as this is just packagekit-qt renamed in a newer release.

Comment 2 Rex Dieter 2008-10-16 18:35:13 UTC
Just a few items:

1.  The 
Obsoletes: libpackagekit-qt ...
should be
Obsoletes: packagekit-qt ...

2.  drop extraneous
Provides:	qpackagekit = %{version}-%{release}
Provides:	qpackagekit-devel = %{version}-%{release}
that's the implicit name of the (sub)package already.

Or did you mean to say:  packagekit-qt here (for backward compatibility)?

3.  -devel summary should be changed to:
Summary:	Development files for %{name}

Comment 3 Steven M. Parrish 2008-10-16 18:45:13 UTC
Fixed, fixed and fixed.  Everything in the same place

https://koji.fedoraproject.org/koji/taskinfo?taskID=884644

Comment 4 Rex Dieter 2008-10-16 18:57:06 UTC
Looks good.

rpmlint relatively happy:
$ rpmlint qpackagekit-*.rpm
qpackagekit.x86_64: W: no-documentation
qpackagekit.x86_64: W: obsolete-not-provided packagekit-qt
qpackagekit-devel.x86_64: W: no-documentation
qpackagekit-devel.x86_64: W: obsolete-not-provided packagekit-qt-devel
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

APPROVED.

Comment 5 Steven M. Parrish 2008-10-16 19:13:54 UTC
New Package CVS Request
=======================
Package Name: qpackagekit
Short Description: Qt bindings for kpackagekit
Owners: tuxbrewr
Branches: F-9, devel
InitialCC: rdieter, kkofler

Comment 6 Dennis Gilmore 2008-10-16 19:49:04 UTC
CVS Done

Comment 7 Steven M. Parrish 2009-01-09 15:03:42 UTC
package is now part of packagekit and has been EOL'd


Note You need to log in before you can comment on or make changes to this bug.