Bug 468918 - FEAT: HTS should check for hardware changes before running tests
Summary: FEAT: HTS should check for hardware changes before running tests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Hardware Certification Program
Classification: Retired
Component: Test Suite (harness)
Version: 5.2
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Greg Nichols
QA Contact: Lawrence Lim
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-28 19:58 UTC by Greg Nichols
Modified: 2014-03-26 00:55 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-27 22:58:07 UTC
Embargoed:


Attachments (Terms of Use)
hardwaretest.py patch adding planning checks (4.78 KB, patch)
2008-11-03 15:33 UTC, Greg Nichols
no flags Details | Diff
certificationtest.py patch to revise status attributes (2.33 KB, patch)
2008-11-03 15:38 UTC, Greg Nichols
no flags Details | Diff
planner.py patch to add checkPlan funtion (1.73 KB, patch)
2008-11-03 15:43 UTC, Greg Nichols
no flags Details | Diff
report.py patch adding format function (909 bytes, patch)
2008-11-03 15:49 UTC, Greg Nichols
no flags Details | Diff
tags.py patch to add status attribute and values (308 bytes, patch)
2008-11-03 15:50 UTC, Greg Nichols
no flags Details | Diff
test.py patch for tracking test planning source (1.13 KB, patch)
2008-11-03 16:41 UTC, Greg Nichols
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:0047 0 normal SHIPPED_LIVE hts bug fix update 2009-01-27 22:57:30 UTC

Description Greg Nichols 2008-10-28 19:58:47 UTC
Description of problem:

HTS should check if the current hardware matches that from any previous test runs.

If differences in hardware are found, HTS should offer the user the option of either aborting the test run.  If the user elects to continue, HTS will add or remove tests as appropriate for the hardware changes.   Results from previous runs will not be affected.

Comment 1 Greg Nichols 2008-11-03 15:33:39 UTC
Created attachment 322316 [details]
hardwaretest.py patch adding planning checks


This patch adds a function to check any existing test plan against the current hardware and test library.   Test planning is now performed on every invocation of the "plan", "certify" and "run" commands.   If there are differences found, the user is notified and asked if they would like to continue.

If the user elects to continue, the test plan is updated in the database, and the command continues.

Comment 2 Greg Nichols 2008-11-03 15:38:09 UTC
Created attachment 322317 [details]
certificationtest.py patch to revise status attributes


This patch revises status attributes for tests stored in the database.  The XML records for tests had storaged whether a test was enabled or disabled in a boolean attribute "disabled".   For the new plan/hardware checks, a third state was needed to represent tests that had been deleted from the plan.  So the "disabled" attribute was replaced with a "status" attribute that has the states, "disabled", "enabled", or "deleted".

Comment 3 Greg Nichols 2008-11-03 15:43:41 UTC
Created attachment 322318 [details]
planner.py patch to add checkPlan funtion


This patch adds the checkPlan function to the Planner class.  This function compares the test plan from the database to a new plan.   Test instances are
matched by generating keys of the form <test name>-<udi>-<logical device name>.

The function returns three collections to the caller (hardwaretest.py's UI code) so that the plan may be updated depending on the user's response.

Comment 4 Greg Nichols 2008-11-03 15:49:13 UTC
Created attachment 322321 [details]
report.py patch adding format function

Added a formatting function.

Comment 5 Greg Nichols 2008-11-03 15:50:08 UTC
Created attachment 322322 [details]
tags.py patch to add status attribute and values

Comment 6 Greg Nichols 2008-11-03 16:41:07 UTC
Created attachment 322338 [details]
test.py patch for tracking test planning source


This patch adds code to track the source of a scheduled test: HAL, Kudzu, or if the test was manually scheduled via "hts plan --add".

Comment 9 Yan Tian 2009-01-16 07:47:55 UTC
Verified in hts-5.3-12, it showed "Warning: The hardware devices have changes. Additional tests are required: ... Would you like to continue? (y|n)" if the hardware changed.

Comment 11 errata-xmlrpc 2009-01-27 22:58:07 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0047.html


Note You need to log in before you can comment on or make changes to this bug.