Bug 472525 - Review Request: kio_sysinfo - KIO slave which shows basic system information
Summary: Review Request: kio_sysinfo - KIO slave which shows basic system information
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lukáš Tinkl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-21 15:04 UTC by Jaroslav Reznik
Modified: 2015-07-13 17:35 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-17 20:00:58 UTC
Type: ---
Embargoed:
ltinkl: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jaroslav Reznik 2008-11-21 15:04:42 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/kio_sysinfo/kio_sysinfo.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kio_sysinfo/kio_sysinfo-20081121-1.fc9.src.rpm
Description: This is a sysinfo:/ KIO slave, which shows basic system information often requested by users.

Comment 1 Rex Dieter 2009-01-27 15:06:15 UTC
Hrm... looks like we kinda forgot about this... let's see if we can get this reviewed soonish, and push with (or near after) kde-4.2.0.

Comment 2 Jaroslav Reznik 2009-01-27 15:30:21 UTC
I hoped so and asked ltinkl for review several times to review this ;-)

Comment 3 Lukáš Tinkl 2009-01-27 16:35:08 UTC
Well hopefully after I'm done with the 4.2.0 updates :)

Comment 4 Lukáš Tinkl 2009-02-13 13:37:56 UTC
RPMLINT:

[ltinkl@localhost ~/tmp/kio_sysinfo-20081121]$ rpmlint kio_sysinfo
kio_sysinfo.spec                    kio_sysinfo-20081121-1.fc9.src.rpm
[ltinkl@localhost ~/tmp/kio_sysinfo-20081121]$ rpmlint kio_sysinfo-20081121-1.fc9.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.

The package cleanly built and meets all the required MUST's with the above exception, I still think it's not necessary to do desktop-file-install as this application provides a service, not a standalone application.

Comment 5 Lukáš Tinkl 2009-02-13 14:07:12 UTC
APPROVED

Comment 6 Jaroslav Reznik 2009-02-13 14:12:34 UTC
New Package CVS Request
=======================
Package Name: kio_sysinfo
Short Description: KIO slave which shows basic system information
Owners: jreznik ltinkl kkofler rdieter than
Branches: F-9 F-10
InitialCC:

Comment 7 Kevin Fenzi 2009-02-14 00:43:26 UTC
cvs done.

Comment 8 Rex Dieter 2009-03-17 20:00:58 UTC
built.


Note You need to log in before you can comment on or make changes to this bug.