Bug 473406 - Review Request: system-config-users-docs - Documentation for administering users and groups
Summary: Review Request: system-config-users-docs - Documentation for administering us...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-28 10:58 UTC by Nils Philippsen
Modified: 2009-01-14 13:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-14 13:26:51 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Nils Philippsen 2008-11-28 10:58:55 UTC
Spec URL: http://nphilipp.fedorapeople.org/review/system-config-users-docs.spec
SRPM URL: http://nphilipp.fedorapeople.org/review/system-config-users-docs-1.0.2-1.fc10.src.rpm
Description: This package contains the online documentation for system-config-users which is a graphical utility for administrating users and groups.

Comment 1 Nils Philippsen 2008-12-08 18:37:54 UTC
NB: The package can only be installed with the related tool (with the same documentation stripped) which I plan to release together with this package (once the review is finished).

I've uploaded new files with some fixes at:
Spec: http://nphilipp.fedorapeople.org/review/system-config-users-docs.spec
SRPM: http://nphilipp.fedorapeople.org/review/system-config-users-docs-1.0.3-1.fc10.src.rpm

Comment 3 Jason Tibbitts 2008-12-19 18:36:39 UTC
This is essentially identical to the other system-config-*-docs packages, so I'll be brief.  rpmlint:
  system-config-users-docs.noarch: W: obsolete-not-provided system-config-users
not a problem.

* source files match upstream.  sha256sum:
  13007e26fca8cb3a6dbb6fbd65dca092ad187761b96f79caa1d792726fce55e9  
   system-config-users-docs-1.0.4.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* rpmlint has acceptable complaints.
* final provides and requires are sane.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK.
* acceptable content

APPROVED

Comment 4 Nils Philippsen 2008-12-19 22:36:36 UTC
Thanks for reviewing!

New Package CVS Request
=======================
Package Name: system-config-users-docs
Short Description: Documentation for administering users and groups
Owners: nphilipp
Branches: F-9 F-10

Comment 5 Kevin Fenzi 2008-12-21 04:37:43 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.