Bug 474141 - Variable names with underscores are highlighted incorrectly patch included
Summary: Variable names with underscores are highlighted incorrectly patch included
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse-shelled
Version: 10
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-02 13:27 UTC by Mat Booth
Modified: 2009-02-05 02:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-02-05 02:16:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Fix syntax highlighting of variable names with underscores (1.03 KB, patch)
2008-12-02 13:28 UTC, Mat Booth
no flags Details | Diff

Description Mat Booth 2008-12-02 13:27:12 UTC
Hi Alexander,

Would you consider adding this patch to ShellEd?

An example of the problem it fixes:

TEST_VAR=xyz # Colored properly
ONE=$TEST_VAR # "_VAR" is not colored
TWO=${TEST_VAR} # "${TEST_VAR}" is not colored

I have submitted this patch upstream also[1], but they seem to be very unresponsive. :-(

[1] http://sourceforge.net/tracker/index.php?func=detail&aid=2149875&group_id=116855&atid=676238

Comment 1 Mat Booth 2008-12-02 13:28:32 UTC
Created attachment 325371 [details]
Fix syntax highlighting of variable names with underscores

Comment 2 Alexander Kurtakov 2008-12-02 13:45:11 UTC
(In reply to comment #0)
> Hi Alexander,
> 
> Would you consider adding this patch to ShellEd?
> 
> An example of the problem it fixes:
> 
> TEST_VAR=xyz # Colored properly
> ONE=$TEST_VAR # "_VAR" is not colored
> TWO=${TEST_VAR} # "${TEST_VAR}" is not colored
> 
> I have submitted this patch upstream also[1], but they seem to be very
> unresponsive. :-(
> 
> [1]
> http://sourceforge.net/tracker/index.php?func=detail&aid=2149875&group_id=116855&atid=676238

Hi Mat,
I'll add your patch in the upstream repository :). Sorry for being unresponsive (alhough i'm one of the devs from 2 weeks).
And I plan to push new upstream release with other cleanups and this fix is going to be part of it for sure.
Hopefully the plugin will be revived so if you have any other fixes push them upstream. I'll try to be as responsive as my time permits.

Comment 3 Mat Booth 2008-12-02 14:33:33 UTC
Heh, I didn't realise that you actually *are* the upstream...

Thanks for the quick response.

Comment 4 TK009 2008-12-07 22:02:38 UTC
This bug has been triaged

Comment 5 Fedora Update System 2009-01-08 15:57:56 UTC
eclipse-shelled-1.0.4-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/eclipse-shelled-1.0.4-1.fc10

Comment 6 Fedora Update System 2009-01-15 02:52:20 UTC
eclipse-shelled-1.0.4-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update eclipse-shelled'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0361

Comment 7 Fedora Update System 2009-02-05 02:16:01 UTC
eclipse-shelled-1.0.4-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.