Bug 474188 - Review Request: python-openoffice - Python libraries for interacting with OpenOffice.org
Summary: Review Request: python-openoffice - Python libraries for interacting with Ope...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 473476
TreeView+ depends on / blocked
 
Reported: 2008-12-02 17:51 UTC by Dan Horák
Modified: 2008-12-08 07:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-08 07:29:49 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Dan Horák 2008-12-02 17:51:42 UTC
Spec URL: http://fedora.danny.cz/tryton/python-openoffice.spec
SRPM URL: http://fedora.danny.cz/tryton/python-openoffice-0.1-0.1.20080929svn33.fc11.src.rpm

Description:
The library is designed to supports both writing Macros called by OOo) and
interacting with OOo from an external Python program (using the UNO bridge).

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=971446

Comment 1 Jason Tibbitts 2008-12-07 04:22:32 UTC
This builds but fails to install for me on rawhide:
  Error: Missing Dependency: python(abi) = 2.5 is needed by package 
   1:openoffice.org-pyuno-3.0.1-12.1.fc11.x86_64 (fedora)
  Error: Missing Dependency: libpython2.5.so.1.0()(64bit) is needed by package 
   1:openoffice.org-pyuno-3.0.1-12.1.fc11.x86_64 (fedora)

Not this package's fault; the dependencies are still screwed up from the puthon 2.6 upgrade in rawhide.  I did an F10 build and it seems to have worked fine.

I have no comprehension of how to test this, so I am only reviewing the packaging.

* source files match upstream.  sha256sum:
   31eaccab565fe2d7aab79a5a9f8048d6c771af9d897db5d68b2d614946836a38  
   openoffice-0.1-r33-20080929.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F10, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   python-openoffice = 0.1-0.1.20080929svn33.fc10
  =
   openoffice.org-pyuno
   python(abi) = 2.5

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Dan Horák 2008-12-07 09:27:26 UTC
New Package CVS Request
=======================
Package Name: python-openoffice
Short Description: Python libraries for interacting with OpenOffice.org
Owners: sharkcz
Branches: F-9 F-10 EL-5

Comment 3 Kevin Fenzi 2008-12-08 00:30:54 UTC
cvs done.

Comment 4 Dan Horák 2008-12-08 07:29:49 UTC
Imported and built. Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.