Bug 475962 - Review Request: mitter - A maemo/GTK+ client for twitter
Summary: Review Request: mitter - A maemo/GTK+ client for twitter
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Conrad Meyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-11 10:53 UTC by Lev Shamardin
Modified: 2008-12-30 23:51 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-30 23:51:27 UTC
Type: ---
Embargoed:
cse.cem+redhatbugz: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)
[Review] (8.23 KB, text/plain)
2008-12-17 12:03 UTC, Conrad Meyer
no flags Details

Description Lev Shamardin 2008-12-11 10:53:44 UTC
Spec URL: http://abbot.fedorapeople.org/mitter.spec
SRPM URL: http://abbot.fedorapeople.org/mitter-0.4.3-1.fc8.src.rpm
Description:
Mitter is a client for Twitter. Currently, you can use it on Linux, Windows and OS X (running PyGTK) and on a console/terminal.

Comment 1 Conrad Meyer 2008-12-17 12:03:03 UTC
Created attachment 327234 [details]
[Review]

Attached is my initial review for the package.

Also: please consider updating from Fedora 8 before it goes End of Line very soon!

Two very simple "BAD"s to fix and then I'll approve this.

Comment 2 Fabian Affolter 2008-12-17 12:11:27 UTC
Something about the .desktop file

'desktop-file-install --vendor="fedora" \' is obsolete for new packages
https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

Comment 3 Conrad Meyer 2008-12-17 12:18:00 UTC
In that case someone needs to fix http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files . In the mean time, you only have one thing to fix and I'll approve :).

Comment 4 Conrad Meyer 2008-12-17 12:18:30 UTC
And it's a very minor thing -- very clean package.

Comment 5 Lev Shamardin 2008-12-18 13:12:18 UTC
I've updated the .spec file and rpms:

Spec URL: http://abbot.fedorapeople.org/mitter.spec
SRPM URL: http://abbot.fedorapeople.org/mitter-0.4.3-1.fc8.src.rpm

Changed the license to GPLv3+ and changed the desktop-file-install command to
desktop-file-install --dir=%{buildroot}%{_datadir}/applications %{name}.desktop
(removed --vendor "" option)

Comment 6 Conrad Meyer 2008-12-18 13:30:17 UTC
Ok, looks good. APPROVED.

Comment 7 Lev Shamardin 2008-12-24 06:27:29 UTC
New Package CVS Request
=======================
Package Name: mitter
Short Description: mitter - A maemo/GTK+ client for twitter
Owners: abbot
Branches: F-9 F-10

Comment 8 Kevin Fenzi 2008-12-25 00:32:25 UTC
cvs done.

Comment 9 Fedora Update System 2008-12-25 13:03:49 UTC
mitter-0.4.3-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mitter-0.4.3-1.fc10

Comment 10 Fedora Update System 2008-12-25 13:05:20 UTC
mitter-0.4.3-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/mitter-0.4.3-1.fc9

Comment 11 Fedora Update System 2008-12-30 23:51:24 UTC
mitter-0.4.3-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2008-12-30 23:51:36 UTC
mitter-0.4.3-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.