Bug 477122 - Review Request: perl-Catalyst-Plugin-Authorization-Roles - Role based authorization for Catalyst based on Catalyst::Plugin::Authentication
Summary: Review Request: perl-Catalyst-Plugin-Authorization-Roles - Role based authori...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 478940 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-19 08:58 UTC by Iain Arnell
Modified: 2009-01-11 23:51 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-21 08:43:48 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2008-12-19 08:58:26 UTC
Spec URL: http://iarnell.fedorapeople.org/perl-Catalyst-Plugin-Authorization-Roles.spec
SRPM URL: http://iarnell.fedorapeople.org/perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc11.src.rpm
Description: 
Role based access control is very simple: every user has a list of roles,
which that user is allowed to assume, and every restricted part of the app
makes an assertion about the necessary roles.

Comment 1 Parag AN(पराग) 2008-12-19 09:28:57 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1009025
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
afef214de7c8084c59fad8a07a640059  Catalyst-Plugin-Authorization-Roles-0.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=45,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.41 cusr  0.05 csys =  0.50 CPU)
+ Package perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc11 =>
   Provides: perl(Catalyst::Plugin::Authorization::Roles) = 0.07
   Requires: perl(Catalyst::Exception) perl(Scalar::Util) perl(Set::Object) perl(strict) perl(warnings)


Suggestions:-
 1) Not needed following in SPEC file
BuildRequires:  perl >= 1:5.8.0

APPROVED.

Comment 2 Iain Arnell 2008-12-20 05:23:48 UTC
New Package CVS Request
=======================
Package Name: perl-Catalyst-Plugin-Authorization-Roles
Short Description: Role based authorization for Catalyst based on Catalyst::Plugin::Authentication
Owners: iarnell
Branches: F-9 F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2008-12-21 04:19:59 UTC
cvs done.

Comment 4 Fedora Update System 2008-12-22 16:44:02 UTC
perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc10

Comment 5 Fedora Update System 2008-12-22 16:44:05 UTC
perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc9

Comment 6 Fedora Update System 2009-01-07 09:28:18 UTC
perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-01-07 09:33:20 UTC
perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 manuel wolfshant 2009-01-11 23:51:09 UTC
*** Bug 478940 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.