Bug 478413 - In rhpl/keyboard.py there is syntax error in function call which masked by "expect *".
In rhpl/keyboard.py there is syntax error in function call which masked by "e...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: rhpl (Show other bugs)
10
All Linux
low Severity medium
: ---
: ---
Assigned To: Anaconda Maintenance Team
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-29 14:13 EST by Alexander Kanevskiy
Modified: 2009-01-05 10:27 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-05 10:27:13 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Fix (696 bytes, patch)
2008-12-29 14:13 EST, Alexander Kanevskiy
no flags Details | Diff

  None (edit)
Description Alexander Kanevskiy 2008-12-29 14:13:58 EST
Created attachment 327927 [details]
Fix

Description of problem:

bus.get_object() can accept only two arguments.


Version-Release number of selected component (if applicable): 
rhpl-0.218-1


How reproducible:

It's hidden by "except *" statement.



Steps to Reproduce:
1.
use command line python:

>>> import dbus
>>> bus = dbus.SystemBus()
>>> hal = dbus.Interface(bus.get_object("org.freedesktop.Hal","/org/freedesktop/Hal/Manager"),"org.freedesktop.Hal.Manager")
>>> kbs = hal.FindDeviceByCapability("input.keyboard")
>>> kb = dbus.Interface(bus.get_object("org.freedesktop.Hal", kbs[0], 'org.freedesktop.Hal.Device'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __init__() takes exactly 3 arguments (2 given)
>>> 

  
Actual results:
Traceback.

Expected results:
kb should be interface to first keyboard device.

Additional info:

See attached patch with fix.
Comment 1 Matěj Cepl 2008-12-29 15:18:45 EST
Sorry, for hijacking of this bug, but when you will be in fixing keyboard.py, could you also fix the indentation:

[matej@viklef rhpl]$ tabnanny keyboard.py
keyboard.py 111 '\t    os.unlink(instPath + "/etc/sysconfig/console/default.kmap")\n'
[matej@viklef rhpl]$

Don't you run everything through tabnanny as part of QA?
Comment 2 Chris Lumens 2009-01-05 10:27:13 EST
This will be fixed in the next build of rhpl.  Thanks for the patch.

Note You need to log in before you can comment on or make changes to this bug.