Description of problem: Steps to reproduce: 1. Create raid 1, 5 or 10 2. Remove disk form raid 3. Check state reported by raid Actual results: Rebuildable degrated array reports the status Broken Expected results: Rebuildable degrated array should report inconsistent state. When we have state when raid could be rebuilded - state should be inconsistent When we have state when raid could not be rebuilded - state should be broken
Patch with fix for this issue in attachment. Please review it and give feedback. Patch include: - fix for "Incorrect status displayed when disk is missing" issue. - fix for "Missing supported RAID configuration in "-l" option" - Bugzilla bug 479395 - fix for "Wrong disk layout in raid01" - no Bugzilla bug.
Created attachment 335314 [details] Patch for DMRAID application
Hi, - ALLOW_ACTIVATE and ALLOW_REBUILD are missing in metadata handler commands - power_cycle_count and bbm_log_size are missing in isw struct Cheers, Giuseppe
Krzysztof, please split this patch into 2, hence distinguishing fixes for this bz and #479325. Please attach plain text patch in order to avoid the double-gziped tarball. Thanks, Heinz
How the patches should be prepared? Patch per bug or patch per few small fixes? How many lines the patch have to have? Every patch should be diff between one DMRAID version (from RHEL5.3 GA distribution) and version with particular fix? (conflicts during patching are possible) Or incremental patches- every new patch should be diff form previous, fixed DMRAID version? (patching order is critical)
Patch per bug. If large change per bug (i.e. > 100 lines of code), split into incremental patches (quilt series) changing one item at a time. Yes, baseline RHEL 5.3 GA, avoiding apply conflicts via quilt series.
Created attachment 339646 [details] Patch for incorrect raid status when disk is missing
Created attachment 339647 [details] Series of patches for DMRAID application - part 1
Fix for incorrect status when disk is missing added in comment 9. It is only one part from series. DMRAID requires series of patches added in comment 10 for correct behavior.
(In reply to comment #11) > Fix for incorrect status when disk is missing added in comment 9. It is only > one part from series. > DMRAID requires series of patches added in comment 10 for correct behavior. It looks the ActivateDegrArray_RH.patch is not prepared properly. Please wait for upgrade. Marcin
I have a question. When will you plan to incorporate our (Intel) DMRAID patches to RHEL5.4? When we may expect first RHEL5.4 drop with our patches?
Krzysztof, Working on it
Patch (id=339647) [details] contains all patches for dmraid in RHEL 5.4. No additional patches shall be applied.
~~ Attention - RHEL 5.4 Beta Released! ~~ RHEL 5.4 Beta has been released! There should be a fix present in the Beta release that addresses this particular request. Please test and report back results here, at your earliest convenience. RHEL 5.4 General Availability release is just around the corner! If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity. Please do not flip the bug status to VERIFIED. Only post your verification results, and if available, update Verified field with the appropriate value. Questions can be posted to this bug or your customer or partner representative.
~~ Attention Partners - RHEL 5.4 Snapshot 1 Released! ~~ RHEL 5.4 Snapshot 1 has been released on partners.redhat.com. If you have already reported your test results, you can safely ignore this request. Otherwise, please notice that there should be a fix available now that addresses this particular request. Please test and report back your results here, at your earliest convenience. The RHEL 5.4 exception freeze is quickly approaching. If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity. Do not flip the bug status to VERIFIED. Instead, please set your Partner ID in the Verified field above if you have successfully verified the resolution of this issue. Further questions can be directed to your Red Hat Partner Manager or other appropriate customer representative.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-1347.html