Spec URL: http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl.spec SRPM URL: http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl-0.11-1.fc10.src.rpm Description: <description here>
MUSTFIX: - Missing BR: to pull in dos2unix I recommend to use /usr/bin/dos2unix and using BR: /usr/bin/dos2unix CONSIDER: - CRLF conversion should be performed on sources, not on installed files.
Created attachment 328838 [details] Proposed spec changes to address issues from comment #1
Thank you for your review. http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl-0.11-2.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl.spec
There is a redundant "Requires: perl(Pod::POM)" in your spec. APPROVED, provided you remove this.
I'll remove it before push to repo. New Package CVS Request ======================= Package Name: perl-Parse-ErrorString-Perl Short Description: Parse error messages from the perl interpreter Owners: mmaslano Branches: F-10 devel InitialCC: perl-sig
cvs done.