Spec URL: http://ruben.fedorapeople.org/python-wokkel.spec SRPM URL: http://ruben.fedorapeople.org/python-wokkel-0.4.0-1.fc11.src.rpm Description: Wokkel is collection of enhancements on top of the Twisted networking framework, written in Python. It mostly provides a testing ground for enhancements to the Jabber/XMPP protocol implementation as found in Twisted Words, that are meant to eventually move there.
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1082699 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 3f6acd2752ad12a3a67bd54ed02698e0 wokkel-0.4.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
Thanks for the review! New Package CVS Request ======================= Package Name: python-wokkel Short Description: Enhancements to the Twisted XMPP protocol implementation Owners: ruben Branches: F-10
cvs done.
is this built so that we can CLOSE this review?
Yep, thanks.