Bug 482763 - Review Request: compat-guichan07 - compatibility libraries for guichan 0.7.1
Summary: Review Request: compat-guichan07 - compatibility libraries for guichan 0.7.1
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexey Torkhov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: RFE:manaworld
TreeView+ depends on / blocked
 
Reported: 2009-01-27 23:21 UTC by Wart
Modified: 2010-10-26 18:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-26 18:38:52 UTC
Type: ---
Embargoed:
atorkhov: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Wart 2009-01-27 23:21:04 UTC
Spec URL: http://www.kobold.org/~wart/fedora/queue/compat-guichan07.spec
SRPM URL: http://www.kobold.org/~wart/fedora/queue/compat-guichan07-0.7.1-1.fc9.src.rpm
Description: Compatibility packages for guichan-0.7.1

This is primarily a rename of the current guichan-0.7.1 package.  The purpose of the rename is so that guichan can be upgraded to 0.8.1 while not breaking compatibility with existing packages that link against guichan-0.7.1.

This compat- package will only be built for F-9.  F-10 and later already contain the more recent guichan-0.8.1.

Comment 1 Alexey Torkhov 2009-03-10 15:53:16 UTC
I think there is no need to do major version bumps of guichan within F-9 release.
Or it is this still actual?

Comment 2 Wart 2009-03-10 17:12:25 UTC
I would prefer not as well, however...

The current version of manaworld is broken in F-9, due to incompatibilities with the central manaworld game servers.  But in order to upgrade manaworld, guichan also needs to be updated.

The last time I checked, there were only 3 packages that used guichan: sear, manaworld, and ballz.

* sear is already using an older compat-guichan-05 package
* ballz is already using the latest guichan in rawhide, and should not be a problem rebuilding against guichan-0.8.1, or just using compat-guichan07
* manaworld upgrade requires guichan 0.8.1

But since there may be end-user packages that have been built against guichan0.7, it is better to introduce the short-lived compat package instead of risking breaking end-user packages.

Comment 3 Alexey Torkhov 2009-03-10 19:07:17 UTC
Well, this seem will work only for people that are built their packages but not simply built againt guichan, as in latter case there will be no dep preventing update from guichan-0.7 to guichan-0.8.

Anyway, here is review:

- rpmlint output:

compat-guichan07.x86_64: W: file-not-utf8 /usr/share/doc/compat-guichan07-0.7.1/COPYING
compat-guichan07.x86_64: W: file-not-utf8 /usr/share/doc/compat-guichan07-0.7.1/README
compat-guichan07.x86_64: W: file-not-utf8 /usr/share/doc/compat-guichan07-0.7.1/NEWS
compat-guichan07.x86_64: W: file-not-utf8 /usr/share/doc/compat-guichan07-0.7.1/AUTHORS
compat-guichan07-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Non-UTF8 files should be fixed for this and for 0.8, if it suffer from this too.

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ File, containing the text of the licenses for the package is included in
  %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
  provided in the spec URL.

275c5bad231d2ce55e654d80cb1e05be  guichan-0.7.1.tar.gz
275c5bad231d2ce55e654d80cb1e05be  guichan-0.7.1.tar.gz

+ The package successfully compiles and builds into binary rpms on at least
  one primary architecture (x86_64).
+ All build dependencies are listed in BuildRequires.
+ No need to deal with locales.
+ Calls ldconfig in %post and %postun.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not contains any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros.
+ The package contains code.
+ Does not contain large documentation.
+ Includes only doc files in %doc.
+ Header files are in a -devel package.
+ No static libraries.
+ No pkgconfig(.pc) files.
+ Library files without suffix are in a -devel package.
+ Devel package require the base package using a fully versioned dependency.
+ Packages does not contain any .la libtool archives.
+ Packages does not contain GUI application.
+ Packages does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in the package are valid UTF-8.

This package is APPROVED.

Comment 4 Peter Lemenkov 2009-04-22 05:58:35 UTC
Ping, Wart.

Comment 5 Wart 2009-05-02 19:43:01 UTC
Importing now.  Sorry for the delay.

Comment 6 Wart 2009-05-02 19:47:07 UTC
New Package CVS Request
=======================
Package Name: compat-guichan07
Short Description: compatibility libraries for guichan 0.7.1
Owners: wart
Branches: F-9

This package is for F-9 only.  F10 and later have an updated version already.

Comment 7 Kevin Fenzi 2009-05-04 03:38:38 UTC
Note that you always get a devel branch. Make sure and follow 
https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life
for the devel branch. 

cvs done.

Comment 8 Alexey Torkhov 2009-06-08 22:34:20 UTC
You seem still need to follow the EOL procedure for devel branch.


Note You need to log in before you can comment on or make changes to this bug.