Spec URL: http://www.squirrel.nl/pub/xfer/chordii.spec SRPM URL: http://www.squirrel.nl/pub/xfer/chordii-4.2-1.src.rpm Description: This is a description of a utility called chordii. It's purpose is to provide guitar players with a tool to produce good looking, self-descriptive music sheets from text files. chordii reads text files containing the lyrics of songs, the chords to be played, their descriptions and some other optional data to produce a PostScript document that includes: Centered titles Chord names above the words Graphical representation of the chords at the end of the songs chordii also provides support for Multiple columns on a page Index of a songbook Multiple logical pages per physical pages (1, 2 or 4) Configurable fonts for the lyrics and the chord names Multiple songs inside one file The complete ISO 8859-1 character set Chorus marking This is my first package, so I'm looking for a sponsor. The spec and srpm are rpmlint free of warnings and errors.
I suggest to remove the first paragraph of the description. The description tag cannot refer to anything but the chordii package, hence "This is a description of a utility called chordii." is redundant. The starting phrase of the second paragraph should be modified accordingly, for instance "The purpose of chordii is to provide guitar players with [...]" Please examine if the build process can take advantage of compiling in parallel on several processors ( http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make ) If the program doesn't build with it, please add a comment otherwise please use it. It would also be a good idea to also add INSTALL="install -p" to the make line, this should preserve the timestamps of the man pages. Please also take a look at the Makefile, according to http://koji.fedoraproject.org/koji/getfile?taskID=1092213&name=build.log the manpages are installed twice. It's not critical now but, if I am not mistaken, patching the Makefile in order to remove the redundant lines (if this is the case) would be a good idea. Did you submit any other packages ? Or maybe you have performed some pre-reviews ?
Thanks for the kind and constructive comments. I've added a patch for the Makefile to eliminate the double install of the man pages, and applied your other suggestions as well. I'll submit a new review request. As for the other questions: I have some more packages I'd like to submit but since this is the first time I first try one package to get used to the procedures.
As you please, I am waiting. 2-3-4 correct packages (depending on complexity and your abilities to fix -- if needed -- errors) will[/might] bring sponsorship :) Please do no forget to increment the release tag each time you submit a modified spec.
Make sure which bug to mark duplicate I see this package submitted by submitter twice. see bug483250
*** This bug has been marked as a duplicate of bug 483250 ***