Bug 483569 - Review Request: perl-MooseX-Types-Set-Object - Set::Object type with coercions and stuff
Summary: Review Request: perl-MooseX-Types-Set-Object - Set::Object type with coercio...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-02-02 14:07 UTC by Allisson Azevedo
Modified: 2012-01-15 22:18 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-02-03 16:36:36 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Allisson Azevedo 2009-02-02 14:07:18 UTC
Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Types-Set-Object/perl-MooseX-Types-Set-Object.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Types-Set-Object/perl-MooseX-Types-Set-Object-0.02-1.fc10.src.rpm

Description: This module provides Moose type constraints (see
Moose::Util::TypeConstraints, MooseX::Types).

Comment 1 Parag AN(पराग) 2009-02-02 16:24:27 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1099489
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
91ca075f77cd9922e36a100c59b6f383  MooseX-Types-Set-Object-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=1, Tests=15,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.32 cusr  0.02 csys =  0.35 CPU)
+ Package perl-MooseX-Types-Set-Object-0.02-1.fc11 ->
Provides: perl(MooseX::Types::Set::Object) = 0.02
Requires: perl(MooseX::Types) perl(MooseX::Types::Moose) perl(Scalar::Util) perl(Set::Object) perl(base) perl(strict) perl(warnings)

 APPROVED.

Comment 2 Allisson Azevedo 2009-02-02 16:29:35 UTC
New Package CVS Request
=======================
Package Name: perl-MooseX-Types-Set-Object
Short Description: Set::Object type with coercions and stuff
Owners: allisson
Branches: F-9 F-10

Comment 3 Kevin Fenzi 2009-02-03 04:19:40 UTC
cvs done.

Comment 4 Iain Arnell 2012-01-15 09:25:33 UTC
Package Change Request
======================
Package Name: perl-MooseX-Types-Set-Object
InitialCC: perl-sig

Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.

Comment 5 Gwyn Ciesla 2012-01-15 22:17:50 UTC
Done.


Note You need to log in before you can comment on or make changes to this bug.