hi, the latest rawhide rpm gstreamer-0.10.22-1.fc11 can't be build on fedora-10 or epel-5 since it's required a newer libtool/ imho it'd be useful to fix somehow: ------------------------------------------------------ make[2]: Entering directory `/tmp/gstreamer-0.10.22/tools' test -z "/usr/bin" || /bin/mkdir -p "/home/lfarkas/rpm/BUILDROOT/gstreamer-0.10.22-1.fc11.i386/usr/bin" /bin/sh ../libtool --mode=install /usr/bin/install -c 'gst-xmllaunch' '/home/lfarkas/rpm/BUILDROOT/gstreamer-0.10.22-1.fc11.i386/usr/bin/gst-xmllaunch' libtool: install: /usr/bin/install -c gst-xmllaunch /home/lfarkas/rpm/BUILDROOT/gstreamer-0.10.22-1.fc11.i386/usr/bin/gst-xmllaunch /bin/sh ../libtool --mode=install /usr/bin/install -c 'gst-xmllaunch-0.10' '/home/lfarkas/rpm/BUILDROOT/gstreamer-0.10.22-1.fc11.i386/usr/bin/gst-xmllaunch-0.10' libtool: install: invalid libtool wrapper script `gst-xmllaunch-0.10' make[2]: *** [install-binPROGRAMS] Error 1 make[2]: Leaving directory `/tmp/gstreamer-0.10.22/tools' make[1]: *** [install-am] Error 2 make[1]: Leaving directory `/tmp/gstreamer-0.10.22/tools' make: *** [install-recursive] Error 1 ------------------------------------------------------
*** Bug 486008 has been marked as a duplicate of this bug. ***
the solution at #486196
0.10.22-3.fc11 fails to rebuild as well.
The "fix" is to revert the changes done in bug 486196. It's not a bug in gstreamer on rawhide anyway, as it builds just fine there. Please test with the instructions above.
it's still wrong! as i wrote i the other bug report do not build with: make %{?_smp_mflags} ERROR_CFLAGS="" LIBTOOL="%{_bindir}/libtool" but with: make %{?_smp_mflags} it's the fedora's recommended way and it's working on _both_ fedora and epel! so it's not just the parallel build can be enabled but use the system libtool. yours.
According to changelog, LIBTOOL voodoo is required to get rid of rpaths. I'll try finding another way.
may be that changelog it outdated! it's no longer needed neither on fedora nor on epel.
Actually, the rpaths will prevent rpmbuild from working if that libtool kludge is removed. However, using the sed trick outlined in Fedora Packaging Guidelines [1]: sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool does not break the build on Fedora 10, while at the same time taking care of the rpath problem. Bastien, Adam, do you want me to commit this fix? [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath
or you can modify it to: --------------------------- %if 0%{?fedora} >= 9 make ERROR_CFLAGS="" LIBTOOL="%{_bindir}/libtool" %else make %{?_smp_mflags} %endif --------------------------- and then everybod will happy. and imho in case of fedora before configure autoreconf libtoolize -f would also be useful since the included libtool is much older then the system one.
In my opinion changes to the autotools-generated files should be kept to minimum.
OK, scratch this. Without provenpackager, I won't be able to commit that. Please merge the fix mentioned in comment #8 (the make line should be changed to plain make %{?_smp_mflags}, and the BR on libtool can be dropped.
any reason why #8 not applied?
I'm waiting for a patch against the F-10 branch.
The bug says that the rawhide rpm can't be rebuilt on F-10, so I believe it's the devel branch that should be patched. In case I'm misunderstanding, you want that change separated from gstreamer update, right?
this patch is for rawhide. i would like to be able to rebuild rawhide's src.rpm on both f10 and epel. with this patch it can be compiled on both. that's why i like to apply it to rawhide's spec file.
Created attachment 339670 [details] idealistic patch Looks like it won't be that easy. I tested the rebuild using rpmbuild and not mock, and it turns out that gstreamer won't rebuild in mock with the attached patch applied. It fails with the following error: gtk-doc: Running scanner gstreamer-scan Use of uninitialized value $ENV{"RUN"} in concatenation (.) or string at /usr/bin/gtkdoc-scangobj line 1548, <TYPES> line 41. /builddir/build/BUILD/gstreamer-0.10.22/docs/gst/.libs/lt-gstreamer-scan: error while loading shared libraries: libgstreamer-0.10.so.0: cannot open shared object file: No such file or directory Scan failed: make[5]: *** [scan-build.stamp] Error 127 make[5]: Leaving directory `/builddir/build/BUILD/gstreamer-0.10.22/docs/gst' make[4]: *** [all] Error 2 make[4]: Leaving directory `/builddir/build/BUILD/gstreamer-0.10.22/docs/gst' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/builddir/build/BUILD/gstreamer-0.10.22/docs' make[2]: *** [all] Error 2 make[2]: Leaving directory `/builddir/build/BUILD/gstreamer-0.10.22/docs' make[1]: make[1]: Leaving directory `/builddir/build/BUILD/gstreamer-0.10.22' *** [all-recursive] Error 1 make: *** [all] Error 2 I think it works with local rpmbuild since I have gstreamer rpm installed. So, I suppose a different approach is needed to solve this problem. Sorry for spreading misinformation, I should have checked more thoroughly.
(In reply to comment #15) > this patch is for rawhide. i would like to be able to rebuild rawhide's src.rpm > on both f10 and epel. with this patch it can be compiled on both. that's why i > like to apply it to rawhide's spec file. Just like I mentioned in bug 486882, we won't be making changes to the rawhide spec file to be able to build on older distributions. If you want to update gstreamer in F-10, feel free to open a new bug with a patch against F-10, and ask for ACLs in pkgdb. If you want to update gstreamer in RHEL, same thing, along with a list of reasons why we should be updating the package.
I've filed an upstream bug about '--disable-rpath' not working in the configure script as shipped. When fixed, this should prevent the need for either the system libtool or the sed hack on Fedora or RHEL. https://bugzilla.gnome.org/show_bug.cgi?id=603275