Bug 485963 - Review Request: perl-MooseX-GlobRef-Object - Store a Moose object in glob reference
Review Request: perl-MooseX-GlobRef-Object - Store a Moose object in glob ref...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-02-17 12:55 EST by Allisson Azevedo
Modified: 2012-01-12 08:22 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-02-18 16:37:19 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Allisson Azevedo 2009-02-17 12:55:29 EST
Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-GlobRef-Object/perl-MooseX-GlobRef-Object.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-GlobRef-Object/perl-MooseX-GlobRef-Object-0.04-1.fc10.src.rpm

Description: This meta-policy allows to store Moose object in glob reference or file
handle. The class attributes will be stored in anonymous hash associated
with glob reference. It allows to create a Moose version of IO::Handle.
Comment 1 manuel wolfshant 2009-02-17 19:59:18 EST

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM: empty
binary RPM:empty
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic (same as perl)
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 82d43233eb7f585b6523cdc8fe2f133a150e9752 MooseX-GlobRef-Object-0.04.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: devel/x86_64
 [?] Package should compile and build into binary rpms on all supported
     Tested on:
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass.

All seem well but according to http://search.cpan.org/dist/MooseX-GlobRef-Object/ the latest release is 0.06, which makes packaging 0.04 a bit odd. Any special reason to use an older version of the tarball ?
Comment 2 Allisson Azevedo 2009-02-17 20:41:34 EST
Thanks for report, i'll update to use latest release.
Comment 3 manuel wolfshant 2009-02-18 02:43:16 EST
I am going to trust you to do it before import. APPROVED
Comment 4 Allisson Azevedo 2009-02-18 05:24:30 EST
New Package CVS Request
Package Name: perl-MooseX-GlobRef-Object
Short Description: Store a Moose object in glob reference
Owners: allisson
Branches: F-9 F-10
Comment 5 Kevin Fenzi 2009-02-18 15:03:25 EST
cvs done.
Comment 6 Petr Pisar 2012-01-12 06:32:48 EST
Package Change Request
Package Name: perl-MooseX-GlobRef-Object
New Branches: 
InitialCC: perl-sig

Please add perl-sig user with watch* permissions only to all Fedora branches.
Comment 7 Gwyn Ciesla 2012-01-12 08:08:49 EST
Comment 8 Iain Arnell 2012-01-12 08:22:49 EST
NOTE. This package has been replaced by perl-MooseX-GlobRef (see bug 591775 and bug 682754). It was already blocked in koji since f16 and I completed the formal retirement earlier today after it was orphaned from cweyl. Please don't try to resurrect it.

Note You need to log in before you can comment on or make changes to this bug.