Bug 486000 - Review Request: perl-CPANPLUS-Shell-Default-Plugins-Changes - View a module's Changes file from the CPANPLUS shell
Review Request: perl-CPANPLUS-Shell-Default-Plugins-Changes - View a module's...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/CPANPLUS-...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-17 15:41 EST by Chris Weyl
Modified: 2009-02-18 16:20 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-18 16:20:09 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2009-02-17 15:41:34 EST
Spec URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Changes.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc10.src.rpm

Description:
This plugin allows you to display the Changes (or Changelog, ChangeLog,
etc) file of a module to get an overview of what (according to the
maintainer) has changed.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1134038
Comment 1 Parag AN(पराग) 2009-02-18 03:15:30 EST
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1134038
+ rpmlint is silent for SRPM
+ rpmlint reported for RPM.
perl-CPANPLUS-Shell-Default-Plugins-Changes.noarch: W: filename-too-long-for-joliet perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc11.noarch.rpm
==> can be ignored as package just follows upstream name.
+ source files match upstream url
3a828b717dc6c2bbb455956212978507  CPANPLUS-Shell-Default-Plugins-Changes-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=5,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.05 cusr  0.00 csys =  0.06 CPU)
+ Package  perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc11 =>
 Provides:
 perl(CPANPLUS::Shell::Default::Plugins::Changes) = 0.02
 Requires:
 perl(CPANPLUS::Error)
 perl(DirHandle)
 perl(Locale::Maketext::Simple)
 perl(strict)
 perl(vars)
 perl(warnings)

APPROVED.
Comment 2 Chris Weyl 2009-02-18 06:07:32 EST
New Package CVS Request
=======================
Package Name: perl-CPANPLUS-Shell-Default-Plugins-Changes
Short Description: View a module's Changes file from the CPANPLUS shell
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-02-18 15:20:56 EST
cvs done.
Comment 4 Chris Weyl 2009-02-18 16:20:09 EST
Thanks for the review! :-)

Note You need to log in before you can comment on or make changes to this bug.