Spec URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Changes.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc10.src.rpm Description: This plugin allows you to display the Changes (or Changelog, ChangeLog, etc) file of a module to get an overview of what (according to the maintainer) has changed. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1134038
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1134038 + rpmlint is silent for SRPM + rpmlint reported for RPM. perl-CPANPLUS-Shell-Default-Plugins-Changes.noarch: W: filename-too-long-for-joliet perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc11.noarch.rpm ==> can be ignored as package just follows upstream name. + source files match upstream url 3a828b717dc6c2bbb455956212978507 CPANPLUS-Shell-Default-Plugins-Changes-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=5, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.06 CPU) + Package perl-CPANPLUS-Shell-Default-Plugins-Changes-0.02-1.fc11 => Provides: perl(CPANPLUS::Shell::Default::Plugins::Changes) = 0.02 Requires: perl(CPANPLUS::Error) perl(DirHandle) perl(Locale::Maketext::Simple) perl(strict) perl(vars) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-CPANPLUS-Shell-Default-Plugins-Changes Short Description: View a module's Changes file from the CPANPLUS shell Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)