Bug 486482 - Review Request: perl-Gnome2 - Perl interface to the 2.x series of the GNOME libraries
Review Request: perl-Gnome2 - Perl interface to the 2.x series of the GNOME l...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
:
: perl-Gnome2 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-19 18:08 EST by Allisson Azevedo
Modified: 2009-02-20 22:14 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-20 22:14:52 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Allisson Azevedo 2009-02-19 18:08:42 EST
Spec URL: http://allisson.fedorapeople.org/packages/perl-Gnome2/perl-Gnome2.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-Gnome2/perl-Gnome2-1.042-1.fc10.src.rpm

Description: The Gnome2 module allows a perl developer to use the Gnome libraries.  Find out
more about Gnome+ at http://www.gnome.org.
Comment 1 Jason Tibbitts 2009-02-19 19:19:35 EST
*** Bug 245342 has been marked as a duplicate of this bug. ***
Comment 2 manuel wolfshant 2009-02-20 07:51:12 EST
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [!] Rpmlint output:
source rpm: empty
binary rpm: perl-Gnome2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gnome2/Install/gnome2perl.h
perl-Gnome2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gnome2/Install/gnome2perl-autogen.h
perl-Gnome2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gnome2/Install/gnome2perl-versions.h
=> see note 1
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
     License type as specified by sources: LGPLv2+ (see Gnome2.pm)
     License type as specified by spec file: LGPLv2
=> please fix before import
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of source file: 8f232afac6ca2e8f6770550e754c857142872a68  Gnome2-1.042.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:koji scratch build
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass


==Notes==
I am not sure here. Do we need /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gnome2/Install in the binary rpm ? If needed, shouldn't it go to a separate devel package ?
Comment 3 Allisson Azevedo 2009-02-20 08:12:57 EST
Hi,

I found similar packages and the .h files is not in -devel:

perl-Gnome2-Canvas: http://koji.fedoraproject.org/koji/rpminfo?rpmID=473861
perl-Gnome2-Print: http://koji.fedoraproject.org/koji/rpminfo?rpmID=474966
perl-Gnome2-GConf: http://koji.fedoraproject.org/koji/rpminfo?rpmID=660415
Comment 4 manuel wolfshant 2009-02-20 09:18:56 EST
package APPROVED. Thanks Marcela for pointing me to the right docs.
Comment 5 Allisson Azevedo 2009-02-20 09:23:45 EST
New Package CVS Request
=======================
Package Name: perl-Gnome2
Short Description: Perl interface to the 2.x series of the GNOME libraries
Owners: allisson
Branches: F-9 F-10
InitialCC: perl-sig
Comment 6 Kevin Fenzi 2009-02-20 15:35:50 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.