Red Hat Bugzilla – Bug 486519
Review Request: thunar-shares-plugin - Thunar file manager extension to share files using Samba
Last modified: 2009-02-24 15:55:56 EST
Spec URL: http://cwickert.fedorapeople.org/review/thunar-shares-plugin.spec
SRPM URL: http://cwickert.fedorapeople.org/review/thunar-shares-plugin-0.2.0-1.fc11.src.rpm
Description: The Thunar Shares plugin allows you to quickly share a folder using Samba from Thunar (the Xfce file manager) without requiring root access. It's backend is based on nautilus-share.
This is basically a re-review of thunar-shares because the package has been renamed.
I'd be happy to review this. Look for a full review in a bit.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
I don't see any blockers here, so this package is APPROVED.
New Package CVS Request
Package Name: thunar-shares-plugin
Short Description: Thunar file manager extension to share files using Samba
Branches: F-10 F-11
thunar-shares-plugin-0.2.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.