Red Hat Bugzilla – Bug 487031
Remove producer throttling
Last modified: 2015-11-15 19:06:51 EST
Flow control commands are sent out through broker::SessionState on a timer thread. If this happens concurrently with e.g. dispatch of message for a subscriber on that session, or when writing out the response/completion for a command other than transfer, there could be corruption of the output stream or other problems as all output is currently assumed to be done serially on the io thread.
This isn't testable except by finding a soak test that fails oddly
Gordon, can this be closed?
It certainly looks like the code was changed.
I think the best thing would be to remove the feature entirely. I don't believe anyone uses it and I don't think it is actually useful. I also don't believe there are any tests for it and I suspect QE don't test it either.
Turning this into a request to remove the producer throttling feature. It's not currently in use, and it has no tests.
Ken, is the old producer-throttling now removed?
No it hasn't been. I've opened an upstream JIRA to issue a warning should that feature be used:
Probably the polite thing to do for 0.14, then rip it out entirely in 0.15 (?)
Thanks. I think that's the right plan.
Removed this from upstream in 0.15 development branch.