Spec URL: http://mmaslano.fedorapeople.org/perl-Class-XSAccessor-Array/perl-Class-XSAccessor-Array.spec SRPM URL: http://mmaslano.fedorapeople.org/perl-Class-XSAccessor-Array/perl-Class-XSAccessor-Array-0.14-1.fc10.src.rpm Description: The module implements fast XS accessors both for getting at and setting an object attribute. Additionally, the module supports mutators and simple predicates (has_foo() like tests for definedness of an attributes). The module works only with objects that are implemented as arrays. Using it on hash-based objects is bound to make your life miserable. Refer to Class::XSAccessor for an implementation that works with hash-based objects.
package build failed. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1190374 Suggestions: 1) You don't need following in SPEC Requires: perl(AutoXS::Header) >= 0.02 2) Missing BuildRequires: perl(Test::More)
(In reply to comment #1) > package build failed. > koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1190374 > > Suggestions: > 1) You don't need following in SPEC > Requires: perl(AutoXS::Header) >= 0.02 > Did you mean BR? It fails without it. http://koji.fedoraproject.org/koji/getfile?taskID=1190561&name=build.log > 2) Missing > BuildRequires: perl(Test::More) Added. Thanks. New koji build could be found at: http://koji.fedoraproject.org/koji/taskinfo?taskID=1190611
(In reply to comment #2) > (In reply to comment #1) > > package build failed. > > koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1190374 > > > > Suggestions: > > 1) You don't need following in SPEC > > Requires: perl(AutoXS::Header) >= 0.02 > > I see this "Requires:" will get automatically installed via yum command. so thought not needed in SPEC. > Did you mean BR? It fails without it. > http://koji.fedoraproject.org/koji/getfile?taskID=1190561&name=build.log > > 2) Missing > > BuildRequires: perl(Test::More) > Added. > > Thanks. New koji build could be found at: > http://koji.fedoraproject.org/koji/taskinfo?taskID=1190611 thanks but I am unable to download SRPM.
That was my fault. I built but didn't upload new srpm. Here it is: http://mmaslano.fedorapeople.org/perl-Class-XSAccessor-Array/perl-Class-XSAccessor-Array-0.14-2.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-Class-XSAccessor-Array/perl-Class-XSAccessor-Array.spec
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1219373 + rpmlint is silent for SRPM and for RPM. + source files match upstream url fe97bdfbfdcfb37260a270d0d8bd4b36 Class-XSAccessor-Array-0.14.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=63, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.17 cusr 0.03 csys = 0.23 CPU) + Package perl-Class-XSAccessor-Array-0.14-2.fc11-i586 => Provides: Array.so perl(Class::XSAccessor::Array) = 0.14 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >= 0:5.006 perl(Carp) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) APPROVED.
New Package CVS Request ======================= Package Name: perl-Class-XSAccessor-Array Short Description: Generate fast XS accessors without runtime compilation Owners: mmaslano Branches: devel InitialCC: perl-sig
cvs done.