Bug 488197 - Review Request: ibus-rawcode - The Rawcode engine for IBus
Review Request: ibus-rawcode - The Rawcode engine for IBus
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-03 01:11 EST by Pravin Satpute
Modified: 2009-03-03 23:39 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-03-03 23:39:54 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Comment 1 Parag AN(पराग) 2009-03-03 02:08:48 EST
you need to BR: ibus-devel as well as need to modify configure.ac to change package requirement from ibus-1.0 to ibus-1.1

Also, change %define to %global in spec.
Comment 2 Parag AN(पराग) 2009-03-03 02:19:53 EST
oops looks like ibus-devel-1.1.0.20090225-1.fc11 in rawhide provides ibus-1.0 not ibus-1.1
Comment 3 Pravin Satpute 2009-03-03 02:52:51 EST
remove %define as it was not require for ibus-rawcode
added BuildRequires: ibus-devel

new url

Spec URL: http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode.spec
SRPM URL:
http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode-1.0.0.20090303-2.fc11.src.rpm
Comment 4 Parag AN(पराग) 2009-03-03 03:46:43 EST
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216185
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
26e7aeb1e54ebbab4de222f67ffe174f  ibus-rawcode-1.0.0.20090303.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package ibus-rawcode-1.0.0.20090303-2.fc11-i586 =>
  Requires: Requires: libc.so.6 libc.so.6(GLIBC_2.0) libdbus-1.so.3 libglib-2.0.so.0 libgobject-2.0.so.0 libibus.so.0 rtld(GNU_HASH)
  Provides: ibus-rawcode = 1.0.0.20090303-2.fc11

APPROVED.
Comment 5 Pravin Satpute 2009-03-03 04:20:06 EST
New Package CVS Request
=======================
Package Name: ibus-rawcode
Short Description: The Rawcode input engine for IBus platform
Owners: pravins
Branches: devel
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2009-03-03 15:45:24 EST
cvs done.
Comment 7 Pravin Satpute 2009-03-03 23:39:54 EST
completed build
Thanks Parag and Kevin

Note You need to log in before you can comment on or make changes to this bug.