Red Hat Bugzilla – Bug 488911
Review Request: perl-Hash-Merge-Simple - Recursively merge two or more hashes, simply
Last modified: 2009-03-08 14:58:15 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Hash-Merge-Simple.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Hash-Merge-Simple-0.04-1.fc10.src.rpm
Hash::Merge::Simple will recursively merge two or more hashes and return
the result as a new hash reference. The merge function will descend and
merge hashes that exist under the same node in both the left and right
hash, but doesn't attempt to combine arrays, objects, scalars, or
anything else. The rightmost hash also takes precedence, replacing
whatever was in the left hash if a conflict occurs. This code was pretty
much taken straight from Catalyst::Utils, and modified to handle more
than 2 hashes at the same time.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1225712
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1225712
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=14, 0 wallclock secs ( 0.00 usr 0.02 sys + 0.10 cusr 0.06 csys = 0.18 CPU)
+ Package perl-Hash-Merge-Simple-0.04-1.fc11-noarch =>
Provides: perl(Hash::Merge::Simple) = 0.04
Requires: perl(strict) perl(vars) perl(warnings)
New Package CVS Request
Package Name: perl-Hash-Merge-Simple
Short Description: Recursively merge two or more hashes, simply
Branches: F-9 F-10 devel
Thanks for the review! :-)