Bug 492600 (oxygen-icon-theme) - Review Request: oxygen-icon-theme - Oxygen Icon Theme
Summary: Review Request: oxygen-icon-theme - Oxygen Icon Theme
Keywords:
Status: CLOSED RAWHIDE
Alias: oxygen-icon-theme
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-27 16:43 UTC by Rex Dieter
Modified: 2009-07-26 20:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-26 20:25:33 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2009-03-27 16:43:59 UTC
Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme.spec
SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme-4.2.1-10.fc10.src.rpm
Description: Oxygen Icon Theme

This was once packaged as part of kdebase-runtime, but upstream kde-artwork team has pending plans to release oxygen separately.  This submission currently still uses the kdebase-runtime tarball, and serves as an intermediate step so that we're ready when proper oxygen releases happen.

Comment 1 Jaroslav Reznik 2009-03-30 15:12:37 UTC
package name: OK
SPEC name matches package name: OK
rpmlint: NOT OK
  - oxygen-icon-theme.noarch: W: no-documentation
  - there are docs in pics/oxygen/, at least COPYING has to be distributed with this package
buildroot: OK
license: NOT OK
  - oxygen theme is licensed under LGPLv3+ not GPLv2
source md5 matches upstream: OK
buildrequires: OK
  - remove bogus BRs after oxygen standalone release
package owns created dirs: NOT OK?
  - main package: OK
  - scalable: ? as rpmls doesn't list created directories
permissions: OK
clean section: OK
no dupes: OK
package builds on: F10

Comment 2 Rex Dieter 2009-03-30 15:29:24 UTC
* Mon Mar 30 2009 Rex Dieter <rdieter> - 4.2.1-11
- License: LGPLv3+
- %%doc: AUTHORS CONTRIBUTING COPYING TODO*

Spec URL:
http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme.spec

(didn't re-up the biggish srpm)

Comment 3 Jaroslav Reznik 2009-03-30 15:47:38 UTC
Ok, thanks.
I'm not sure about owner of all scalable directories.

Comment 4 Rex Dieter 2009-03-30 18:08:23 UTC
The parent pkg owns all dirs.

Fwiw, it would seem that for future releases, it would appear that upstream will drop these from distribution anyway.

Comment 5 Jaroslav Reznik 2009-03-30 20:19:23 UTC
Well, APPROVED.

Comment 6 Rex Dieter 2009-03-30 20:47:26 UTC
New Package CVS Request
=======================
Package Name: oxygen-icon-theme
Short Description: Oxygen Icon Theme
Owners: rdieter,than,jreznik,ltinkl,kkofler
Branches: F-9 F-10

Comment 7 Kevin Fenzi 2009-03-30 21:37:14 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.