Bug 494493 - Review Request: hyphen-gu - Gujarati hyphenation rules
Summary: Review Request: hyphen-gu - Gujarati hyphenation rules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-07 08:02 UTC by Caolan McNamara
Modified: 2009-04-08 08:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-08 08:41:56 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-04-07 08:02:20 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-gu.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-gu-0.20081213-1.fc10.src.rpm
Description: Gujarati hyphenation rules

Comment 1 Parag AN(पराग) 2009-04-07 08:21:40 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1281831
+ rpmlint output for SRPM and for RPM is
hyphen-gu.noarch: W: no-documentation
==> can be ignored as there is no document files and license is added in hyph_gu_IN.dic
+ source files match upstream.
c0d49e2c424e38cc20351b7c56ad087a  hyph_gu_IN.dic
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2009-04-07 08:25:32 UTC
New Package CVS Request
=======================
Package Name: hyphen-gu
Short Description: Gujarati hyphenation rules
Owners: caolanm
Branches: F-11, devel
InitialCC: caolanm

Comment 3 Kevin Fenzi 2009-04-08 02:48:21 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.