Red Hat Bugzilla – Bug 495278
Review Request: perl-DBIx-Class-DateTime-Epoch - Automatic inflation/deflation of epoch-based DateTime objects for DBIx::Class
Last modified: 2009-04-12 16:24:24 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DateTime-Epoch.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DateTime-Epoch-0.03-1.fc10.src.rpm
This module automatically inflates/deflates DateTime objects
corresponding to applicable columns. Columns may also be defined to
specify their nature, such as columns representing a creation time
(set at time of insertion) or a modification time (set at time of
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1290500
+ source files match upstream.
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
+ package installs properly.
+ rpmlint has no complaints:
perl-DBIx-Class-DateTime-Epoch.noarch: I: checking
perl-DBIx-Class-DateTime-Epoch.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(DBIx::Class::DateTime::Epoch) = 0.03
perl-DBIx-Class-DateTime-Epoch = 0.03-1.fc11
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass.
All tests successful.
Files=3, Tests=3, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.34 cusr 0.03 csys = 0.40 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
New Package CVS Request
Package Name: perl-DBIx-Class-DateTime-Epoch
Short Description: Automatic inflation/deflation of epoch-based DateTime objects for DBIx::Class
Branches: F-9 F-10 devel
Thanks for the review! :-)