Bug 495327 - Review Request: python-cly - A module for adding powerful text-based consoles to your Python application
Review Request: python-cly - A module for adding powerful text-based consoles...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Susi Lehtola
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-11 21:06 EDT by Silas Sewell
Modified: 2009-04-12 15:11 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-04-12 15:11:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
susi.lehtola: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Silas Sewell 2009-04-11 21:06:25 EDT
Spec URL: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/python-cly/python-cly.spec

SRPM URL: http://silassewell.googlecode.com/files/python-cly-0.9-1.fc10.src.rpm

Description: CLY is a Python module for simplifying the creation of interactive shells, much like the built-in "cmd" module on steroids.

rpmlint

[silas@silas result]$ rpmlint python-cly-0.9-1.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[silas@silas result]$ rpmlint python-cly-0.9-1.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 1 Susi Lehtola 2009-04-12 04:23:16 EDT
rpmlint output is clean.

MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK


The package is

APPROVED


PS. Just a stylish note: maybe use
make -C doc/
instead of
make --directory doc/
Comment 2 Silas Sewell 2009-04-12 04:37:35 EDT
Thanks for the review Jussi.

New Package CVS Request
=======================
Package Name: python-cly
Short Description: A module for adding powerful text-based consoles to your Python application
Owners: silas
Branches:
InitialCC:
Comment 3 Kevin Fenzi 2009-04-12 14:34:29 EDT
cvs done.
Comment 4 Silas Sewell 2009-04-12 15:11:43 EDT
Built, thanks Jussi and Kevin.

Note You need to log in before you can comment on or make changes to this bug.