Bug 49616 - rc.sysinit still not robust enough in module configuration checks
Summary: rc.sysinit still not robust enough in module configuration checks
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: initscripts
Version: 7.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Brock Organ
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2001-07-21 17:16 UTC by Michal Jaegermann
Modified: 2014-03-17 02:21 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2001-07-23 21:18:02 UTC


Attachments (Terms of Use)

Description Michal Jaegermann 2001-07-21 17:16:37 UTC
Description of Problem:

Lines like

if grep -q "options sound dmabuf=1" /etc/modules.conf ...

in /etc/rc.d/rc.sysinit are faulty because they will be found
even if this line is commented out but they will be missed if
white space is used in a different way.  To solve both problems
at the same time this should really read:

if modprobe -c | grep -q "options sound dmabuf=1" ....

OTOH lines with

if modprobe -c | egrep -s "<elaborate matching pattern>" ...

are really only waisting CPU cycles, especially if an output is
piped to 'awk', because:

   1) 'modprobe -c' normalizes white space in its output anyway
   2)  the whole job could be done in awk only and in a simpler
       manner.

Right now this looks like a close relative of a "dead cat".

P.S.  It _seems_ to me that I was already submitting in the past
a bug report like that. But I could not find any traces in my notes
nor while searching on bugzilla.  Maybe I only intended to?

Comment 1 Glen Foster 2001-07-23 21:17:58 UTC
This defect is considered SHOULD-FIX for Fairfax.

Comment 2 Bill Nottingham 2001-08-07 06:39:30 UTC
Should be fixed in initscripts-6.12-1.


Note You need to log in before you can comment on or make changes to this bug.